Closed
Bug 397373
Opened 17 years ago
Closed 17 years ago
Make &state=disabled work again
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: micmon, Assigned: ventnor.bugzilla)
Details
Attachments
(1 file)
943 bytes,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
pavlov
:
approval1.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)
For perfect OS integration on Linux/GNOME it would be very nice if we could create a theme that always picks up the icons from the GTK icon theme.
This is possible today, by using moz-icon://stock/*. The only problem so far is that I am unable to create the disabled state of buttons, because there is no way to display a button in grayscale and XUL doesn't seem to do this itself (when the button is "disabled").
Now, creating separate icons for disabled stats would be possible, but it also defeats the whole purpose of this. So, would it be possible to provide a "-moz-disabled" property, similar to -moz-opacity, which draws the icon with less saturation to make it look gray/disabled?
Reproducible: Always
Updated•17 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk
Assignee | ||
Comment 1•17 years ago
|
||
Just add &state=disabled to the end of the icon URL, but it is broken at the moment. This is actually because of a typo I found in the code a little while ago, I have a patch for it coming up.
Assignee | ||
Comment 2•17 years ago
|
||
Simple typo, trivial patch, we're only human.
Assignee: nobody → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #284791 -
Flags: superreview?(pavlov)
Attachment #284791 -
Flags: review?(pavlov)
Updated•17 years ago
|
Severity: enhancement → normal
Component: OS Integration → ImageLib
Product: Firefox → Core
QA Contact: os.integration → imagelib
Updated•17 years ago
|
Summary: Add a way to grayscale icon → Make &state=disabled work again
Updated•17 years ago
|
Attachment #284791 -
Flags: superreview?(pavlov)
Attachment #284791 -
Flags: superreview+
Attachment #284791 -
Flags: review?(pavlov)
Attachment #284791 -
Flags: review+
Assignee | ||
Updated•17 years ago
|
Attachment #284791 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #284791 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Comment 3•17 years ago
|
||
Checking in modules/libpr0n/decoders/icon/nsIconURI.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/icon/nsIconURI.cpp,v <-- nsIconURI.cpp
new revision: 1.28; previous revision: 1.27
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
You need to log in
before you can comment on or make changes to this bug.
Description
•