"ASSERTION: Doing nscoord addition with values > nscoord_MAX" with percentage margin in table cell

RESOLVED FIXED

Status

()

Core
Layout: Tables
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Jesse Ruderman, Assigned: dholbert)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
x86
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
Created attachment 282211 [details]
testcase

Loading the testcase triggers two of the new assertions added in bug 367673:

###!!! ASSERTION: Doing nscoord addition with values > nscoord_MAX: 'a < nscoord_MAX && b < nscoord_MAX', file ../../dist/include/gfx/nsCoord.h, line 151

###!!! ASSERTION: nscoord addition will reach or pass nscoord_MAX: '(PRInt64)a + (PRInt64)b < (PRInt64)nscoord_MAX', file ../../dist/include/gfx/nsCoord.h, line 153
Created attachment 282274 [details] [diff] [review]
fix

trivial -- we just need one more call to NSCoordSaturatingAdd.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #282274 - Flags: superreview?(roc)
Attachment #282274 - Flags: review?(roc)
Attachment #282274 - Flags: approval1.9?
Attachment #282274 - Flags: superreview?(roc)
Attachment #282274 - Flags: superreview+
Attachment #282274 - Flags: review?(roc)
Attachment #282274 - Flags: review+
Attachment #282274 - Flags: approval1.9?
Attachment #282274 - Flags: approval1.9+
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Depends on: 368573
Flags: in-testsuite?
(Reporter)

Comment 3

11 years ago
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.