Embed characters to children not 1:1

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: Scott Haeger, Assigned: surkov)

Tracking

(Blocks: 1 bug, {access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.62 KB, patch
Aaron Leventhal
: review+
Mike Schroepfer
: approval1.9+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
The slider seen here http://www.mozilla.org/access/dhtml/pretty-slider.htm shows that it has an embed character but has a childCount=0.  This should not occur because embed characters to children should be a 1:1 match.
(Reporter)

Comment 1

10 years ago
Here are a couple more examples that demonstrate the problem:

http://test.cita.uiuc.edu/aria/button/xhtml.php?title=Button%20Example%201&ginc=includes/button1a.inc&gcss=css/button1a.css&gjs=../js/globals.js,../js/enable_app.js,js/button1a.js

http://test.cita.uiuc.edu/aria/button/html.php?title=Button%20Example%201&ginc=includes/button1.inc&gcss=css/button1.css&gjs=../js/globals.js,../js/enable_app.js,js/button1.js

Please note that testing was done on the Gecko/2007091604 build, which was before the build that caused many issues.
(Reporter)

Updated

10 years ago
Blocks: 374212

Updated

10 years ago
Blocks: 396346

Comment 2

10 years ago
Scott, is this still a problem?
Keywords: access
(Reporter)

Comment 3

10 years ago
Yes, this is still an issue.  However, Orca now has safe guards for this so it is a low priority item.

Updated

10 years ago
Assignee: aaronleventhal → surkov.alexander

Comment 4

10 years ago
ROLE_SLIDER is in nsAccessible::MustPrune()
So the childCount is always zero.

Do we want to change that?

Comment 5

10 years ago
btw: the child in the slider is <span class "bar">, the moving square bar.
 

Comment 6

10 years ago
Ginn, we don't want extra image children in a slider. It confuses screen readers like JAWS that have doc browsing modes.

It would be better if MustPrune()==TRUE means that there are no embedded object chars in something, and that it doesn't support nsIAccessibleHyperText.

Comment 7

10 years ago
Actually I'm not sure, because nsIAccessible does have the children. We'd need the embedded object chars when exposing it there and not when exposing it to ATK. Yuck.
(Reporter)

Comment 8

10 years ago
Ginn, I am looking at it from an ATK point of view where I am only given a slider object.  It should have no children either in the Accessible::childCount field or as and embed character in the text interface.

I just checked with Accerciser and it is still an issue.  As mentioned earlier, this is no longer a major issue for Orca.

Comment 9

10 years ago
Scott, BTW, any image child of the slider should probably be role="presentation". But, I believe there is a funky 0x0 object there which takes focus, which is odd in any case.

Comment 10

10 years ago
Sorry, I'm confused.

The child of the slider is not focusable. 

Can we just disable AccessibleText interface and AccessibleTextEditable interface for slider?

Comment 11

10 years ago
Ginn, that will help with slider, it's a good idea.

It won't help with button though, and other items where MustPrune() is true, because we need to expose AccessibleText interface there. However, they could have an image child.

Comment 12

10 years ago
Aaron,

if we don't care nsIAccessible, can we just replace kEmbeddedObjectChar to whitespace in this case?

Sounds like a simple solution?
(Assignee)

Comment 13

10 years ago
Created attachment 288494 [details] [diff] [review]
quick ginn's version
Attachment #288494 - Flags: review?(aaronleventhal)
(Assignee)

Updated

10 years ago
Attachment #288494 - Flags: review?(ginn.chen)

Comment 14

10 years ago
Comment on attachment 288494 [details] [diff] [review]
quick ginn's version

TextLength() and other things that increment the offset by 1 for embedded objects would need to be changed. I think that's why Ginn was suggesting a space character as opposed to no character.
Attachment #288494 - Flags: review?(ginn.chen)
Attachment #288494 - Flags: review?(aaronleventhal)
Attachment #288494 - Flags: review-

Comment 15

10 years ago
Surkov, another problem with this approach is described in comment 7. When MustPrune() is true we only prune for ATK, AT-SPI and UA. We dan't prune for nsIAccessible.

This is going to take a little more thought.
(Assignee)

Comment 16

10 years ago
(In reply to comment #15)
> Surkov, another problem with this approach is described in comment 7. When
> MustPrune() is true we only prune for ATK, AT-SPI and UA. We dan't prune for
> nsIAccessible.

We do (http://lxr.mozilla.org/mozilla/source/accessible/src/msaa/nsAccessibleWrap.cpp#242). 
(Assignee)

Comment 17

10 years ago
Created attachment 288660 [details] [diff] [review]
patch
Attachment #288494 - Attachment is obsolete: true
Attachment #288660 - Flags: review?(aaronleventhal)

Comment 18

10 years ago
Comment on attachment 288660 [details] [diff] [review]
patch

I think space is a good idea, because if there is an embedded object char like an image between two words we do want to separate them somehow.

nit: hans't -> hasn't
Attachment #288660 - Flags: review?(aaronleventhal) → review+
(Assignee)

Updated

10 years ago
Attachment #288660 - Flags: approval1.9?

Updated

10 years ago
Attachment #288660 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 19

10 years ago
checked in, unfortunately I forot to fix misspeling :(
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.