Closed Bug 397538 Opened 17 years ago Closed 17 years ago

[Mac] Right-click on event in calendar brings up non-functioning pop-up menu

Categories

(Calendar :: Calendar Frontend, defect)

PowerPC
macOS
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: susanne, Assigned: berend.cornelius09)

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7
Build Identifier: 2007092503

Right-click on event brings up "edit" and "delete" option in pop-up menu. Clicking on one of these options however has no effect whatsoever. 

Reproducible: Always

Steps to Reproduce:
1.create event
2.go to any calendar view, right-click on event
3.click on either "edit" or "delete"
Actual Results:  
nothing

Expected Results:  
edit window appears
Are you getting any errors in the error console? Which version of thunderbird/lightning/sunbird are you using?

This seems quite critical if it can be confirmed, requesting blocking just in case.
Flags: blocking-calendar0.7?
TB version 2.0.0.6 (20070728)
There were no errors. I think now that part of it is my problem. There seems to be no error when you actually click on the event, then right-click to edit. However, if you just put the cursor over the event (without clicking it) and then right-click, it brings up the edit/delete option as opposed to the previous month/next month/new event options in the rest of that day field. 
When a day in month view is already highlighted (for instance if you've just created an event by double clicking that day) it is sort of hard to tell if the day or the event itself are highlighted. The edit/delete pop up is sort of misleading then.
Sorry for the confusion. 
I confirm this. Found this on Calendar 0.7 RC 2 test day as well.
As for error console, saw this:

"Warning: Error in parsing value for property '-moz-image-region'.  Declaration dropped.
Source File: chrome://calendar/skin/calendar-toolbar.css
Line: 192"

not sure if it's related as I didn't open error console prior to trying this.
Confirmed by comment#3.

On Windows right-click on event _highlights_ it and opens the working context menu.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Right-click on event in calendar brings up non-functioning pop-up menu → [Mac] Right-click on event in calendar brings up non-functioning pop-up menu
May I suggest something? Working context menu is important function. IMO it should be fixed for 0.7 and RC3 for Mac should be created.
Needs to be fixed; Berend volunteered to take a look.
Flags: blocking-calendar0.7? → blocking-calendar0.7+
We've evaluated that bug and there is an easy workaround: Select the item explicitly before opening the context menu. => blocking-
Flags: blocking-calendar0.7+ → blocking-calendar0.7-
Attached patch fix...Splinter Review
On the Mac platform the calendar-event was not selected before the context menu was raised. I added a contextmenu-handler for this which seems to work well to me.
Assignee: nobody → Berend.Cornelius
Status: NEW → ASSIGNED
Attachment #285388 - Flags: review?(michael.buettner)
Comment on attachment 285388 [details] [diff] [review]
fix...

>     <handlers>
>+      <handler event="contextmenu" phase="capturing">
I was curious why we need to handle the 'contextmenu' event in the capture phase instead of handling it in the bubbling phase. Of course, it's because the item boxes each define their own 'contextmenu' handler, see [1], where the dom element naturally exists further down in the tree. So that's why this one gets called earlier. Showing the context menu stops further propagation of the event, which is why the handler at the top of the binding doesn't get called. So, it's indeed the correct solution to handle the event in the capturing phase but keep the event going. Nice solution -> r=mickey.

[1] http://lxr.mozilla.org/mozilla1.8/source/calendar/base/content/calendar-view-core.xml#58
Attachment #285388 - Flags: review?(michael.buettner) → review+
checked in the patch on trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: wanted-calendar0.8?
Resolution: --- → FIXED
Flags: wanted-calendar0.8?
Target Milestone: --- → 0.8
Verified in Lightning build 2007111803 and Sunbird build 20071118 -> task is fixed.
Status: RESOLVED → VERIFIED
Flags: blocking-calendar0.7-
You need to log in before you can comment on or make changes to this bug.