Status

defect
P2
blocker
RESOLVED FIXED
12 years ago
8 months ago

People

(Reporter: cmtalbert, Assigned: jay)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Reporter

Description

12 years ago
Many people have reported wanting to resize the window.  It's unclear if the window really needs to be resizable (we want it to fit comfortable on the same screen as the browser with low resolution monitors) or if it just needs to start out as a better size.

1. Start the QAX window

== Expected Results ==
User doesn't feel constrained and doesn't feel the need to immediately resize the window.

== Actual Results ==
For some reason, the current window size and design makes users feel like they want to grab that edge and resize the window.
This is Vista, and it does need the ability to be resized.

Are you guys making sizeToContent() calls?
(In reply to comment #1)
> Created an attachment (id=282659) [details]
> Screenshot of QAX window
> 
> This is Vista, and it does need the ability to be resized.
> 
> Are you guys making sizeToContent() calls?

Ah, sorry, I see this is covered (at least partially) by bug 396784.
Assignee

Comment 3

12 years ago
This is about giving the user a choice... so I think we should make the window resizable.  As a compromise, we can always launch it at our "recommended" size, but give users the chance to make it smaller/bigger based on their systems and needs.

People with huge monitors or those that don't like the narrow look and wrapped lines in some of the tabs should be able to go bigger if they want.

Marking blocker to get this on the radar and making it a P2 in case we decide this isn't worth the trouble right now.
Severity: normal → blocker
Priority: -- → P2
im seeing horrible layout rendering on the 0.1.6 build against the trunk nightly Proto theme.  the buttons are clipped, the tabs are cut off, and the text needs tooltips for those that are too long to display.

See attachment.
Assignee

Updated

12 years ago
Assignee: zach → jay
Assignee

Comment 5

12 years ago
Clint:  I have tested this pretty thoroughly, so please make sure I didn't do anything too dumb.  Most of the resizing works pretty well, but there were a few minor things I couldn't figure out. If what I have so far looks good, give me the r= so I can check it in.  Thanks!
Attachment #300864 - Flags: review?(ctalbert)
Assignee

Updated

12 years ago
Status: NEW → ASSIGNED
Assignee

Updated

12 years ago
Attachment #300864 - Attachment is obsolete: true
Attachment #300864 - Flags: review?(ctalbert)
Assignee

Comment 6

12 years ago
Last .diff file wasn't viewable... hopefully this works.
Attachment #300865 - Flags: review?(ctalbert)
Reporter

Comment 7

12 years ago
Comment on attachment 300865 [details] [diff] [review]
Super resizing patch, with other UI/string changes... (checking patch box this time)

Jay, this looks really good.  I have some very minor spacing and style nits, but otherwise the code looks great.  I like the way you rearranged the Litmus dialog too.

r=ctalbert.

>Index: chrome/content/qa.xul
>===================================================================
>RCS file: /cvsroot/mozilla/testing/extensions/community/chrome/content/qa.xul,v
>    // on load, set an event listener to deal with saving settings when
>     // changing tabs
>     window.addEventListener('load', function() {
>         $('qa_tabrow').addEventListener('select', qaMain.onSwitchTab, false);
>     }, false);
> </script>
> 
>-<tabbox id="qa_tabbox">
>+  
>+<tabbox id="qa_tabbox" flex="1" pack="start" >    
^ Got some extra spaces at the end of this line

>Index: chrome/content/settings.js
>===================================================================
>RCS file: /cvsroot/mozilla/testing/extensions/community/chrome/content/settings.js,v
>retrieving revision 1.7
>diff -u -8 -p -r1.7 settings.js
>--- chrome/content/settings.js	10 Sep 2007 22:01:06 -0000	1.7
>+++ chrome/content/settings.js	1 Feb 2008 11:47:07 -0000
>@@ -56,16 +56,41 @@ var qaPrefsWindow = {
>+  
>+  /*
>+  disableAll : function() {
>+        if ($("qa-prefs-notify-disableall").checked) {
>+            $("qa-prefs-notify-disableall").checked = false;
>+            $("qa-prefs-notify-testday").disabled = false;
>+            $("qa-prefs-notify-bugday").disabled = false;
>+            $("qa-prefs-notify-prerelease").disabled = false;
>+            $("qa-prefs-notify-qmo").disabled = false;
>+            $("qa-prefs-notify-newbuild").disabled = false;
>+            $("qa-prefs-notify-other").disabled = false;
>+            
>+        } else {
>+            $("qa-prefs-notify-disableall").checked = true;
>+            $("qa-prefs-notify-testday").disabled = true;
>+            $("qa-prefs-notify-bugday").disabled = true;
>+            $("qa-prefs-notify-prerelease").disabled = true;
>+            $("qa-prefs-notify-qmo").disabled = true;
>+            $("qa-prefs-notify-newbuild").disabled = true;
>+            $("qa-prefs-notify-other").disabled = true;
>+            
>+        }
>+  },
>+  */
>+  
Got blank lines of only spaces - take out the spaces.  Also, if you don't want this feature in anymore, just
remove it.  The CVS history will show that this section was removed if we want to put it 
back in later.
>
>-
>+    
>   loadSysconfig : function() {
>     $('qa-setup-sysconfig-loading').value =
>       $("bundle_qa").getString("qa.extension.sysconfig.loadingMsg");
Blank line of spaces up there ^^

> 
>     var guessInfo = function() {
>       var sysconfig;
>       try {
>         sysconfig = new Sysconfig();
>
>Index: chrome/content/tabs/bugzilla.xul
>===================================================================
>RCS file: /cvsroot/mozilla/testing/extensions/community/chrome/content/tabs/bugzilla.xul,v
>-        <radio selected="true" id="qa-bugzilla-radio-id"
>-                   label="Bug id:" width="100px" />
>-         <textbox width="200px" id="qa-bugzilla-input-id" />
>-      </hbox>
>-      <hbox><radio id="qa-bugzilla-radio-words" label="Keywords:" width="100px" />
>-          <textbox width="200px" disabled="true" id="qa-bugzilla-input-keywords" /> </hbox>
>-      </radiogroup>
>-      <hbox>
>-          <checkbox id="qa-bugzilla-input-os" label="Include OS" />
>-          <checkbox id="qa-bugzilla-input-version" label="Include Version" />
>+        <radio class="bug-search" selected="true" id="qa-bugzilla-radio-id" 
>+               label="Bug Id:" />
Extra space at the end of this line ^

>+        <textbox id="qa-bugzilla-input-id" width="75px" />
>+        <spacer width="5px" />
>+        <radio class="bug-search" id="qa-bugzilla-radio-words" 
>+               label="Keywords:" />
>+        <textbox disabled="true" id="qa-bugzilla-input-keywords" flex="1" />
>       </hbox>
>-      <spacer height="20px" />
>-      <hbox>
>-        <button label="Find!" oncommand="bugzilla.doSearch(); "/>
>-         <button label="Show all bugs filed today"
>-                 oncommand="bugzilla.showRecent()"/></hbox>
>+    </radiogroup>
>+    <spacer height="5px" />
>+    <hbox>
>+      <label value="Filter by my:" />
>+      <checkbox id="qa-bugzilla-input-os" label="Operating System" />
>+      <spacer width="5px" />
>+      <checkbox id="qa-bugzilla-input-version" label="Product Version" />
>+    </hbox>
>+    <hbox>
>+      <button style="margin-left: 50px; padding-left: 2em; padding-right: 2em;" 
>+              label="Find!" oncommand="bugzilla.doSearch(); "/>
Here too ^
>+      <button style="padding-left: 2em; padding-right: 2em;" 
And here ^

>Index: chrome/content/tabs/settings.xul
>===================================================================
>RCS file: /cvsroot/mozilla/testing/extensions/community/chrome/content/tabs/settings.xul,v
>retrieving revision 1.6
>diff -u -8 -p -r1.6 settings.xul
>--- chrome/content/tabs/settings.xul	10 Sep 2007 22:01:06 -0000	1.6
>+++ chrome/content/tabs/settings.xul	1 Feb 2008 11:47:07 -0000
>@@ -46,45 +46,50 @@
> 
> <stringbundleset id="stringbundleset">
>   <stringbundle id="bundle_qa" src="chrome://qa/locale/qa.properties" />
> </stringbundleset>
> 
> <tabpanel id="qa-tab-settings">
> <vbox flex="1">
>   <groupbox>
>-    <caption label="&qa.preferences.litmus.title;" />
>+      <caption label="&qa.preferences.litmus.title;" />
>+      <hbox>
>       <label control="qa-preferences-litmus-username"
>-             value="&qa.preferences.litmus.username;"/>
>-      <textbox id="qa-preferences-litmus-username" />
>+             value="&qa.preferences.litmus.username;" width="60px" />
>+      <textbox id="qa-preferences-litmus-username" width="200px" />
No space between last attribute and />
>+      </hbox>
>+      <hbox>
>       <label control="qa-preferences-litmus-password"
>-             value="&qa.preferences.litmus.password;"/>
>-      <textbox id="qa-preferences-litmus-password" type="password" />
>+             value="&qa.preferences.litmus.password;" width="60px" />
>+      <textbox id="qa-preferences-litmus-password" type="password" width="200px" />
Extra space

>+      </hbox>
>       <hbox>
>-      <button id="qa-preferences-litmus-createAccount"
>+      <button style="margin-left: 50px; padding-left: 2em; padding-right: 2em;" 
Extra space at then end of line ^
> 
>-  <groupbox id="qa-prefs-notify">
>+  <groupbox id="qa-prefs-notify" flex="1">
>     <caption label="&qa.preferences.notification.title;" />
>-    <checkbox id="qa-prefs-notify-disableall"
>-              label="&qa.preferences.notification.disableall;" />
>+    <!-- <checkbox id="qa-prefs-notify-disableall"
>+              label="&qa.preferences.notification.disableall;" 
>+              onclick="qaPrefsWindow.disableAll();"/> -->
We should probably just take this out rather than commenting it out and open a follow on bug
to add the functionality back in if we think it's really worth it.
>     <description>&qa.preferences.notification.header;</description>
>     <checkbox id="qa-prefs-notify-testday"
>               label="&qa.preferences.notification.testday;" />
>     <checkbox id="qa-prefs-notify-bugday"
>               label="&qa.preferences.notification.bugday;" />
>     <checkbox id="qa-prefs-notify-prerelease"
>               label="&qa.preferences.notification.prerelease;" />
>     <checkbox id="qa-prefs-notify-qmo"
>               label="&qa.preferences.notification.qmo;" />
>     <checkbox id="qa-prefs-notify-newbuild"
>               label="&qa.preferences.notification.newbuild;" />
>     <checkbox id="qa-prefs-notify-other"
>               label="&qa.preferences.notification.other;" />
>   </groupbox>
>+  
Blank line of spaces ^^
Attachment #300865 - Flags: review?(ctalbert) → review+
Assignee

Comment 8

12 years ago
Checked in my changes.  Please log separate bugs for remaining issues/requests related to resizing.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Webtools → Other Applications
Version: Trunk → unspecified

Updated

8 months ago
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.