397644 - input type="file" not exposed correctly

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Steve Lee]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007092404 Minefield/3.0a9pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007092404 Minefield/3.0a9pre

An input file is show as a role=text and does not have STATUS_FOCUSABLE.
in addition it has no action interface (it should have Press)

Reproducible: Always

Steps to Reproduce:
1.open a page with a input type="file"
2.use accerciser to view the accessible and action interfaces
3.



The are other design issues with input type="file" but these problem need fixing whatever. See 345195

Comment 1

[Aaron Leventhal]

i'm not even getting role_text, I get a BSTR role of input. I guess the file input control is totally broken for accessibility.

Comment 2

[Aaron Leventhal]

Also, the Browse... button fires events but I don't see it in the top-down hierarchy.

Comment 3

[Aaron Leventhal]

Attachment: 1) Don't create accessible for file control frame itself (nsBlockFrame::GetAccessible() generically creates accessibles now), and 2) Revert to frame walking to find accessibles for input type="file"

This is a special case fix for file controls, which returns things to how they were before we removed our broken :before/:after accessible object support.

Although special casing file control here is not pretty, it's good because it is not risky and time is short for Firefox 3. I think this is the best thing for now.

We may do more frame walking later for controls with anon content.
We also may no longer need to do this if Firefox moves to a mac-like file control. It's not yet clear.

Comment 4

[Aaron Leventhal]

Comment on attachment 282563 [details] [diff] [review]
1) Don't create accessible for file control frame itself (nsBlockFrame::GetAccessible() generically creates accessibles now), and 2) Revert to frame walking to find accessibles for input type="file"

Correct patch coming up.

Comment 5

[Aaron Leventhal]

Attachment: Correct patch

Comment 6

[alexander :surkov (:asurkov)]

I would have special accessible class than to burden nsAccessibleTreeWalker

Comment 7

[Aaron Leventhal]

Surkov, we can do that after FF3. This was low risk because it worked this way before.

Comment 8

[alexander :surkov (:asurkov)]

(In reply to comment #7)
> Surkov, we can do that after FF3. This was low risk because it worked this way
> before.
> 

Sure, I don't mind just should we have bug to track it?