397683 - Graph server displays time relative to local time zone

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

I see different dates on graphs.mozilla.org if I change the TZ environment variable before launching my browser. By default, I see times that are three hours ahead of the times on Tinderbox, because I'm 3 hours of PDT. The graphs should show the same times regardless of local browser settings (PST/PDT, presumably).

Comment 1

[Karl Tomlinson (:karlt)]

It's debatable what the best arrangement is.

If tinderbox, bonsai, and graphs all gave local times/dates then that could be quite convenient.

But it would be good if everything is consistent, and the timezone should be specified.

(A switch to change the timezone is a possibility too I guess.)

Comment 2

[alice nodelman [:alice] [:anode]]

Attachment: force graph server dates to pst/pdt

This patch should force all dates to be displayed in pst/pdt so that they don't differ from those displayed on the tinderbox pages.

I'm pretty new to this whole date/time/timezones/dst confusion, so I'm not sure if this is the best approach.

Comment 3

[alice nodelman [:alice] [:anode]]

Attachment: force graph server dates to pst/pdt

I think that I was still getting local vs. UTC confused in that last patch.

Timezones are hard.

Comment 4

[alice nodelman [:alice] [:anode]]

Checking in GraphCanvas.js;
/cvsroot/mozilla/webtools/new-graph/js/GraphCanvas.js,v  <--  GraphCanvas.js
new revision: 1.22; previous revision: 1.21
done