Closed Bug 397686 Opened 17 years ago Closed 17 years ago

Talos platform detection broken on Vista

Categories

(Release Engineering :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: johnath, Assigned: bhearsum)

References

Details

Attachments

(1 file)

Several places in the Talos python code use this test to detect windows:

platform.system() == "Windows"

On Vista, with python 2.5, platform.system() returns "Microsoft".  Those instances should likely be changed to:

platform.system() in ("Windows", "Microsoft")
This patch adds support for Windows Vista to Talos. The only change that needed to be made was in the platform detection code. I've tested this on one of our Vista machines and it runs fine. It should be noted that Talos needs be launched from a command line that has been "run as administrator".
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #284670 - Flags: review?(anodelman)
Attachment #284670 - Flags: review?(anodelman) → review+
Checking in ffprocess.py;
/cvsroot/mozilla/testing/performance/talos/ffprocess.py,v  <--  ffprocess.py
new revision: 1.7; previous revision: 1.6
done
Checking in ffsetup.py;
/cvsroot/mozilla/testing/performance/talos/ffsetup.py,v  <--  ffsetup.py
new revision: 1.3; previous revision: 1.2
done
Checking in ttest.py;
/cvsroot/mozilla/testing/performance/talos/ttest.py,v  <--  ttest.py
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Mass move of Core:Testing bugs to mozilla.org:ReleaseEngineering. Filter on RelEngMassMove to ignore.
Component: Testing → Release Engineering
Product: Core → mozilla.org
QA Contact: testing → release
Version: unspecified → other
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: