397686 - Talos platform detection broken on Vista

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Johnathan Nightingale [:johnath]]

Several places in the Talos python code use this test to detect windows:

platform.system() == "Windows"

On Vista, with python 2.5, platform.system() returns "Microsoft".  Those instances should likely be changed to:

platform.system() in ("Windows", "Microsoft")

Comment 1

[[e-mail] (:bhearsum)]

Attachment: vista support for talos

This patch adds support for Windows Vista to Talos. The only change that needed to be made was in the platform detection code. I've tested this on one of our Vista machines and it runs fine. It should be noted that Talos needs be launched from a command line that has been "run as administrator".

Comment 2

[[e-mail] (:bhearsum)]

Checking in ffprocess.py;
/cvsroot/mozilla/testing/performance/talos/ffprocess.py,v  <--  ffprocess.py
new revision: 1.7; previous revision: 1.6
done
Checking in ffsetup.py;
/cvsroot/mozilla/testing/performance/talos/ffsetup.py,v  <--  ffsetup.py
new revision: 1.3; previous revision: 1.2
done
Checking in ttest.py;
/cvsroot/mozilla/testing/performance/talos/ttest.py,v  <--  ttest.py
new revision: 1.3; previous revision: 1.2
done

Comment 3

[(not currently active) Ted Mielczarek]

Mass move of Core:Testing bugs to mozilla.org:ReleaseEngineering. Filter on RelEngMassMove to ignore.