Closed Bug 397690 Opened 19 years ago Closed 18 years ago

clean up handler app-executable-display hackiness

Categories

(Firefox :: Settings UI, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jimm, Assigned: jimm)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [not needed for 1.9])

Attachments

(2 files)

Attached patch patch v.1 — — Splinter Review
In applications.js, describePreferredAction & rebuildActionsMenu pull the name for various types of handers from nsIHanderInfo's preferredApplicationHandler name property. This traces to nsLocalHandlerApp's GetName, which returns the LeafName instead of the full application name.
Attachment #282458 - Flags: review?(myk)
Comment on attachment 282458 [details] [diff] [review] patch v.1 Hmm, this seems like a good fix, although I wonder if we should make nsILocalHandlerApp::name return the full application name rather than the leaf name.
Attachment #282458 - Flags: review?(myk) → review+
Biesi, dmose: should we make nsILocalHandlerApp::name return the full application name instead of the leaf name? The full name seems more useful in the Applications prefpane context at least (and would mean the prefpane controller wouldn't have to retrieve the full names itself).
Comment on attachment 282458 [details] [diff] [review] patch v.1 Requesting approval for this low-risk polish fix that improves the appearance and comprehensibility of application names in the Applications prefpane.
Attachment #282458 - Flags: approval1.9?
Attachment #282458 - Flags: approval1.9? → approval1.9+
Yes, the current behavior is really a bug in nsLocalHandlerApp, given how nsIHandlerApp.name is defined. This will be hard to fix until nsLocalHandlerApp can do per-platform overrides. That change is coming in bug 394483. Landing the patch here as a temporary workaround would be reasonable, though. If that happens, I'd suggest keeping this bug open to do the more correct fix after the patch in bug 394483 lands.
Assignee: nobody → jmathies
Checking in browser/components/preferences/applications.js; /cvsroot/mozilla/browser/components/preferences/applications.js,v <-- applications.js new revision: 1.14; previous revision: 1.13 done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Sorry, somehow I missed comment 4. Reopening to do the more correct fix after the patch in bug 394483 lands.
Status: RESOLVED → REOPENED
Depends on: 394483
Resolution: FIXED → ---
Hmm, I just noticed that we need to check if the preferred application handler is a local app as well before calling getDisplayNameForFile on it in _describePreferredAction. Here's a patch that makes that change.
Attachment #282800 - Flags: review?(gavin.sharp)
Attachment #282800 - Flags: review?(gavin.sharp) → review+
Comment on attachment 282800 [details] [diff] [review] followup patch: fixes bug Requesting approval for this low-risk followup fix to a previously-approved patch.
Attachment #282800 - Flags: approval1.9?
Attachment #282800 - Flags: approval1.9? → approval1.9+
Followup patch checked in: Checking in browser/components/preferences/applications.js; /cvsroot/mozilla/browser/components/preferences/applications.js,v <-- applications.js new revision: 1.15; previous revision: 1.14 done Leaving this open for the more correct fix per comment 4.
Assignee: jmathies → nobody
Status: REOPENED → NEW
Assignee: nobody → jmathies
Assignee: jmathies → nobody
Comment on attachment 282800 [details] [diff] [review] followup patch: fixes bug Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT. Please re-request approval if needed.
Attachment #282800 - Flags: approval1.9+
Comment on attachment 282458 [details] [diff] [review] patch v.1 Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT. Please re-request approval if needed.
Attachment #282458 - Flags: approval1.9+
Comment on attachment 282800 [details] [diff] [review] followup patch: fixes bug Already landed. See comment #9.
Attachment #282800 - Flags: approval1.9?
Comment on attachment 282458 [details] [diff] [review] patch v.1 Already landed. See comment #5.
Attachment #282458 - Flags: approval1.9?
Comment on attachment 282800 [details] [diff] [review] followup patch: fixes bug Reset approval flag to + as it was already checked in.
Attachment #282800 - Flags: approval1.9? → approval1.9+
Comment on attachment 282458 [details] [diff] [review] patch v.1 Reset approval flag to + as it was already checked in.
Attachment #282458 - Flags: approval1.9? → approval1.9+
Should this be marked FIXED?
Keywords: verifyme
(In reply to comment #16) > Should this be marked FIXED? Quoting comment #9, "Leaving this open for the more correct fix per comment 4."
Maybe someone can give this a priority, I'm not sure what it should be targeting. I'll probably be able to fix this pretty quickly though (prior to M10).
Assignee: nobody → jmathies
This probably shouldn't be a blocker at this point, so the right thing to do is probably to let this slide to post Firefox-3 and work on blockers rather than giving this a priority. :-/
Blocks: 393122
Summary: Handler apps display as executables rather than full application name → cleanup handler app executable display hackiness
Depends on: 400852
I'm rolling the new name impl in with 400852 since I need the proper name for the protocol dialog. Undoing the temp fix will still be open here.
Summary: cleanup handler app executable display hackiness → clean up handler app-executable-display hackiness
Looks like both patches landed is that right? If so can we close the bug?
Does bug 400852 cover all the "hackiness cleanup" needed here? If not, can you file a new bug to track that? Bug morphing after a patch has already landed just leads to trouble.
Whiteboard: [not needed for 1.9]
Sure, this can be closed.
Status: NEW → RESOLVED
Closed: 19 years ago → 18 years ago
Resolution: --- → FIXED
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: