397695 - Remove checkForChromelessWindow() code

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Johnathan Nightingale [:johnath]]

Bug 337344 was originally going to be resolved by using a notification bar on chromeless windows to warn users, and give them a way to restore chrome.  A version of this was checked in, but it caused mochitest failures, so the preference controlling it was toggled off by default.  The bug was eventually resolved differently, by preventing location bar hiding, but the original (default disabled) code remains in trunk.  While it's sort of nice to have, off by default and non-discoverable means it should probably just be backed out, especially since it's in the Txul critical path.

Comment 1

[Johnathan Nightingale [:johnath]]

Attachment: Backout changes to browser.js, properties, and prefs

MXR confirms no one else uses checkForChromelessWindow() or showToolbars(), or references the pref.

Comment 2

[Johnathan Nightingale [:johnath]]

It's actually in delayedStartup, so it might not be a perf hit either way.  If we don't intend to use it though, I guess we might as well still back it out.

Comment 3

[Reed Loden [:reed]]

Attachment: unbitrotten patch

Comment 4

[Reed Loden [:reed]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.872; previous revision: 1.871
done
Checking in browser/locales/en-US/chrome/browser/browser.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.properties,v  <--  browser.properties
new revision: 1.50; previous revision: 1.49
done
Checking in browser/app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.210; previous revision: 1.209
done

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified via Bonsai.