397792 - Widgets rotated in the wrong direction

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Colin Barrett [:cbarrett]]

Attachment: testcase

Similar to bug 379429, but basic widgets are rotating in the wrong direction instead of images. (buttons don't rotate at all, but I think that's because we're using compositeToPoint instead of drawAtPoint. Haven't verified though).

Testcase based on roc's testcase for bug 380203.

Comment 1

[Colin Barrett [:cbarrett]]

Attachment: fix v1.0

Turns out cairo's transform matrix is defined as:
[xx yx 0]
[xy yy 0]
[x0 y0 1]

while CG's is defined:
[a  b  0]
[c  d  0]
[tx ty 1]

We weren't passing in the params in the right order (we had xy and yx backwards), so the transform matrix was screwed up. Thanks to vlad for helping me figure this out over IRC.

Comment 2

[Colin Barrett [:cbarrett]]

Checking in widget/src/cocoa/nsNativeThemeCocoa.mm;
/cvsroot/mozilla/widget/src/cocoa/nsNativeThemeCocoa.mm,v  <--  nsNativeThemeCocoa.mm
new revision: 1.60; previous revision: 1.59

Comment 3

[Jesse Ruderman]

There's still a lot broken with the testcase: the dropdown's text is outside of the dropdown, things disappear when clicked, and the button never rotates.  Are there bugs on those other issues?

Comment 4

[Colin Barrett [:cbarrett]]

There will be, yes.