Widgets rotated in the wrong direction

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: cbarrett, Assigned: cbarrett)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Created attachment 282575 [details]
testcase

Similar to bug 379429, but basic widgets are rotating in the wrong direction instead of images. (buttons don't rotate at all, but I think that's because we're using compositeToPoint instead of drawAtPoint. Haven't verified though).

Testcase based on roc's testcase for bug 380203.
(Assignee)

Comment 1

11 years ago
Created attachment 282786 [details] [diff] [review]
fix v1.0

Turns out cairo's transform matrix is defined as:
[xx yx 0]
[xy yy 0]
[x0 y0 1]

while CG's is defined:
[a  b  0]
[c  d  0]
[tx ty 1]

We weren't passing in the params in the right order (we had xy and yx backwards), so the transform matrix was screwed up. Thanks to vlad for helping me figure this out over IRC.
Attachment #282786 - Flags: review?(joshmoz)
Attachment #282786 - Flags: review?(joshmoz)
Attachment #282786 - Flags: review+
Attachment #282786 - Flags: approval1.9+
(Assignee)

Updated

11 years ago
Attachment #282786 - Flags: superreview?(pavlov)
(Assignee)

Updated

11 years ago
Attachment #282786 - Flags: superreview?(pavlov)
(Assignee)

Comment 2

11 years ago
Checking in widget/src/cocoa/nsNativeThemeCocoa.mm;
/cvsroot/mozilla/widget/src/cocoa/nsNativeThemeCocoa.mm,v  <--  nsNativeThemeCocoa.mm
new revision: 1.60; previous revision: 1.59
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 3

11 years ago
There's still a lot broken with the testcase: the dropdown's text is outside of the dropdown, things disappear when clicked, and the button never rotates.  Are there bugs on those other issues?
(Assignee)

Comment 4

11 years ago
There will be, yes.
You need to log in before you can comment on or make changes to this bug.