Closed Bug 397852 Opened 13 years ago Closed 13 years ago

"ASSERTION: Doing nscoord addition with values > nscoord_MAX" with table, margin:100%, overflow:auto

Categories

(Core :: Layout: Tables, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached file testcase
Loading the testcase triggers:

###!!! ASSERTION: Doing nscoord addition with values > nscoord_MAX: 'a < nscoord_MAX && b < nscoord_MAX', file ../../dist/include/gfx/nsCoord.h, line 151

###!!! ASSERTION: nscoord addition will reach or pass nscoord_MAX: '(PRInt64)a + (PRInt64)b < (PRInt64)nscoord_MAX', file ../../dist/include/gfx/nsCoord.h, line 153
Attached patch fixSplinter Review
Trivial -- need to check for nscoord_MAX overflow when adding scroll bar pref-width to an infinite-width scrolled frame.
Attachment #282719 - Flags: review?(roc)
Attachment #282719 - Flags: superreview+
Attachment #282719 - Flags: review?(roc)
Attachment #282719 - Flags: review+
Attachment #282719 - Flags: approval1.9+
Status: NEW → ASSIGNED
Fix committed:

Checking in nsGfxScrollFrame.cpp;
/cvsroot/mozilla/layout/generic/nsGfxScrollFrame.cpp,v  <--  nsGfxScrollFrame.cpp
new revision: 3.314; previous revision: 3.313
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
OS: Mac OS X → All
Resolution: --- → FIXED
Flags: in-testsuite?
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
Assignee: nobody → dholbert
You need to log in before you can comment on or make changes to this bug.