Closed
Bug 397877
Opened 17 years ago
Closed 17 years ago
Rename Content-Access-Control to Access-Control
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: annevk, Assigned: uriber)
References
Details
Attachments
(1 file)
|
2.52 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
sicking
:
approval1.9+
|
Details | Diff | Splinter Review |
Per http://dev.w3.org/2006/waf/access-control/Overview.html the name of the header to check is Access-Control and not Content-Access-Control.
This should be changed before releasing Firefox 3 because otherwise renaming will become hairy.
Flags: blocking1.9?
|
Assignee | |
Comment 1•17 years ago
|
||
Assignee: nobody → uriber
Status: NEW → ASSIGNED
Attachment #282901 -
Flags: superreview?(jst)
Attachment #282901 -
Flags: review?(jonas)
|
||
Updated•17 years ago
|
Keywords: dev-doc-needed
Attachment #282901 -
Flags: superreview?(jst)
Attachment #282901 -
Flags: superreview+
Attachment #282901 -
Flags: review?(jonas)
Attachment #282901 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #282901 -
Flags: approval1.9?
Attachment #282901 -
Flags: review+
Attachment #282901 -
Flags: approval1.9?
Attachment #282901 -
Flags: approval1.9+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Sorry, I checked this in about 12 hours ago but forgot to resolve the bug. Should be fixed in the 2007-10-01 builds.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
|
|
||
Comment 3•17 years ago
|
||
Uri, when you check in a patch with tests (or one which changes existing tests to respond to changes made in a bug) in the future, please make sure to flip the in-testsuite flag to +. Thanks!
Flags: in-testsuite+
|
||
Comment 4•17 years ago
|
||
Removing dev-doc-needed tag since there is no documentation that uses the incorrect name.
Keywords: dev-doc-needed
|
||
Comment 5•17 years ago
|
||
So I assume checking the "Allow" header for POST and the "Access-Control" header for GET is actually per spec or something?
For POST we should be checking both the 'Allow' header *and* the Access-Control header. Is that not happening?
|
|
||
Comment 7•17 years ago
|
||
It probably is, then. I just saw us obviously checking the Allow header.
|
Reporter | |
Updated•10 years ago
|
Flags: blocking1.9?
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•