397906 - ed2k protocol (and others?) preferred application never remembered

Status: VERIFIED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Steve England [:stevee]]

Attachment: html page with an ed2k:// link

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007092720 Minefield/3.0a9pre ID:2007092720

1. New profile, start firefox
2. Load testcase page
3. click on ed2k:// link
4. The 'Launch Application' dialog appears. Choose to open the file with your favourite edonkey client, and tick "Remember my choice for ed2k links."
5. Click OK (Your edonkey client is opened, and the file is added to your download queue).
6. Remove the download from your edonkey client
7. In firefox, click on the ed2k link again

Expected:
- No 'Launch Application' dialog should appear (because you told firefox to remember how to handle ed2k links); ed2k link should be automatically passed into your edonkey client with no prompting.

Actual:
- 'Launch Application' dialog appears again, and re-asks you how to handle ed2k links, even tho you've told firefox to open them with your favourite edonkey client.

Comment 1

[Steve England [:stevee]]

setting network.protocol-handler.warn-external-default to false makes everything work fine. So my questions are:

1) why is network.protocol-handler.warn-external-default set to true by default?

2) why doesn't my user-set preference wrt the newly-added ed2k protocol ("always open ed2k protocol links with eMule") over-rule network.protocol-handler.warn-external-default=true?

Comment 2

[Barrie North]

this happens with Azereus/Vuze's 'magnet:' links also...

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to comment #1)
> setting network.protocol-handler.warn-external-default to false makes
> everything work fine. So my questions are:
> 
> 1) why is network.protocol-handler.warn-external-default set to true by
> default?

This is by design; see bug 402771 for the most recent iteration of this discussion.
 
> 2) why doesn't my user-set preference wrt the newly-added ed2k protocol
> ("always open ed2k protocol links with eMule") over-rule
> network.protocol-handler.warn-external-default=true?

This is the bug.  Patch forthcoming. 

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: use warning pref to default alwaysAskBeforeHandling, v1

The user's explicit alwaysAskBeforeHandling setting should override any default of the dialog popping up.  So really, the warn preference just needs to be used to default that setting in the case where the user hasn't yet said anything explicitly.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 290936 [details] [diff] [review]
use warning pref to default alwaysAskBeforeHandling, v1



+      (*aHandlerInfo)->SetAlwaysAskBeforeHandling(warn);
+
+    } else {

remove that blank line please

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Checked in, with the blank line removed.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120705 Minefield/3.0b2pre; the testcase in comment 0 works fine for me now.