398017 - nsGenericElement and nsJSEventListener unlink improvements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robert Sayre]

While working on a smaller version of bug 397206, I noticed this message in the DEBUG_CC messages:

nsCycleCollector: nsGenericElement 0x345eb430 in component 152
  was not collected due to missing call to suspect, failure to unlink,
  or deficiency in traverse that causes cycles referenced only from other
  cycles to require multiple rounds of cycle collection
nsCycleCollector: nsGenericElement 0x345e9650 in component 95
  was not collected due to missing call to suspect, failure to unlink,
  or deficiency in traverse that causes cycles referenced only from other
  cycles to require multiple rounds of cycle collection
nsCycleCollector: nsEventListenerManager 0x345eb460 in component 152
  was not collected due to missing call to suspect, failure to unlink,
  or deficiency in traverse that causes cycles referenced only from other
  cycles to require multiple rounds of cycle collection
nsCycleCollector: nsEventListenerManager 0x345e9680 in component 95
  was not collected due to missing call to suspect, failure to unlink,
  or deficiency in traverse that causes cycles referenced only from other
  cycles to require multiple rounds of cycle collection
nsCycleCollector: nsJSEventListener 0x345eb490 in component 152
  was not collected due to missing call to suspect, failure to unlink,
  or deficiency in traverse that causes cycles referenced only from other
  cycles to require multiple rounds of cycle collection
nsCycleCollector: nsJSEventListener 0x345e96b0 in component 95
  was not collected due to missing call to suspect, failure to unlink,
  or deficiency in traverse that causes cycles referenced only from other
  cycles to require multiple rounds of cycle collection

Comment 1

[Robert Sayre]

Attachment: unlink more things

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 282847 [details] [diff] [review]
unlink more things

The change in nsJSEventListener.cpp isn't needed anymore on trunk. Probably still want the change in nsGenericElement.cpp.

Comment 3

[Damon Sicore (:damons)]

Comment on attachment 282847 [details] [diff] [review]
unlink more things

a=release drivers

Comment 4

[Robert Sayre]

Attachment: patch for checkin