398057 - X Window error or crash on shutdown (with GTK < 2.10)

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Simon Montagu :smontagu]

In builds from the last couple of days, the first run always crashes with the following stack:

#6  0xb768fd77 in XFreeGC () from /usr/lib/libX11.so.6
#7  0xb7897cbe in _gdk_gc_x11_get_type () from /usr/lib/libgdk-x11-2.0.so.0
#8  0xb7645f48 in g_object_unref () from /usr/lib/libgobject-2.0.so.0
#9  0xb7880237 in gdk_screen_get_type () from /usr/lib/libgdk-x11-2.0.so.0
#10 0xb78a1169 in gdk_screen_set_default_colormap ()
   from /usr/lib/libgdk-x11-2.0.so.0
#11 0xb76469f4 in g_object_run_dispose () from /usr/lib/libgobject-2.0.so.0
#12 0xb7880312 in _gdk_screen_close () from /usr/lib/libgdk-x11-2.0.so.0
#13 0xb788a7cf in gdk_x11_display_ungrab () from /usr/lib/libgdk-x11-2.0.so.0
#14 0xb76469f4 in g_object_run_dispose () from /usr/lib/libgobject-2.0.so.0
#15 0xb786c0bb in gdk_display_close () from /usr/lib/libgdk-x11-2.0.so.0
#16 0xb7d6fe41 in XRE_main (argc=4, argv=0xbfeff494, aAppData=0x804c9a0)
    at /home/smontagu/mozwork/debugtree/mozilla/toolkit/xre/nsAppRunner.cpp:3217#17 
0x08048b0a in main (argc=4, argv=0xbfeff494)
    at /home/smontagu/mozwork/debugtree/mozilla/suite/app/nsSuiteApp.cpp:99

Subsequent runs either crash on shutdown with the same stack (except that frame 16 is at line 3233), or issue this error message:

The program 'Gecko' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadAtom (invalid Atom parameter)'.
  (Details: serial 9474 error_code 5 request_code 18 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

Reverting bug 394466 makes the problem go away.

I have gtk 2.8.20

Comment 1

[Mark Banner (:standard8)]

I've replicated this with FF, SM and TB builds on gtk 2.8.3. Either crashes on shutdown or restart.

Therefore requesting blocking 1.9.

Comment 2

[Christian Persch (GNOME) (away; not receiving bug mail)]

gdk_display_close doesn't work on gtk < 2.10. [http://bugzilla.gnome.org/show_bug.cgi?id=85715]

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> gdk_display_close doesn't work on gtk < 2.10.
> [http://bugzilla.gnome.org/show_bug.cgi?id=85715]
> 
Interesting. A change to 2.10 for the runtime requirements has been *proposed* in http://wiki.mozilla.org/Linux/Runtime_Requirements (it is currently 2.0+), but no responses to the discussion page/follow up announcements confirming the proposals either way have been made AFAIK.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> Interesting. A change to 2.10 for the runtime requirements has been *proposed*
> in http://wiki.mozilla.org/Linux/Runtime_Requirements (it is currently 2.0+),
> but no responses to the discussion page/follow up announcements confirming the
> proposals either way have been made AFAIK.

I should have said, I'm not against the requirements being upped. I am against upping the requirements without telling anyone beforehand (a proposal is just a proposal).

Comment 5

[Karl Tomlinson (:karlt)]

(In reply to comment #2)
> gdk_display_close doesn't work on gtk < 2.10.
> [http://bugzilla.gnome.org/show_bug.cgi?id=85715]

Thanks, Christian.  I wasn't aware of that.

(In reply to comment #4)
> I should have said, I'm not against the requirements being upped. I am against
> upping the requirements without telling anyone beforehand (a proposal is just
> a proposal).
> 

http://groups.google.com/group/mozilla.dev.planning/tree/browse_frm/month/2007-06/03e8e62d0140f8ab?rnum=151&_done=%2Fgroup%2Fmozilla.dev.planning%2Fbrowse_frm%2Fmonth%2F2007-06%3F#doc_b243528a69d69d2a

(from June) does say "the current set, which we expect to adopt fairly soon."
Not clear, no, but not a complete secret either.

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: don't gdk_display_close when broken at build time but still XCloseDisplay

A build-time work-around.

I still want the display closed for bug 246313.

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: don't gdk_display_close when broken at run time but still XCloseDisplay

The runtime check is pretty simple so let's do that.

Comment 8

[Robert Kaiser]

I see the same problem with GTK 2.12.0, but I see you're checking for 2.10 in the patch so I may see this working after the patch as well.
For crash reports from my system, see bp-18a7ad5c-70f1-11dc-8093-001a4bd43ed6 bp-47679859-70f1-11dc-a8eb-001a4bd43e5c bp-7ef7af9e-70f1-11dc-97f9-001a4bd43ef6 and bp-b37c501c-70f1-11dc-bc80-001a4bd43ed6 - those happened either on startup (after profile selection) when I tried launching the builds from konqueror or on shutdown when I had started the build from a console window.

Comment 9

[Robert Kaiser]

Karl requested a stack for my debug build, I'm posting it here inline because it's that short:

#5  <signal handler called>
#6  0xb3401840 in ?? ()
#7  0xb77cab2a in g_cclosure_marshal_VOID__BOOLEAN () from /usr/lib/libgobject-2.0.so.0
#8  0xb77bd919 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#9  0xb77d09ed in ?? () from /usr/lib/libgobject-2.0.so.0
#10 0x08461fe8 in ?? ()
#11 0x00000000 in ?? ()

Comment 10

[Reed Loden [:reed]]

Checking in toolkit/xre/nsAppRunner.cpp;
/cvsroot/mozilla/toolkit/xre/nsAppRunner.cpp,v  <--  nsAppRunner.cpp
new revision: 1.195; previous revision: 1.194
done

Comment 11

[Karl Tomlinson (:karlt)]

(In reply to comment #9)

Filed bug 398512 on that.

Comment 12

[Mark Banner (:standard8)]

Bug appears fixed for me so removing the blocking request flag.