Closed
Bug 398069
Opened 17 years ago
Closed 17 years ago
Don't cancel resume-from-0 transfers for HTTP 200 responses
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: Mardak, Assigned: Mardak)
Details
Attachments
(1 file, 1 obsolete file)
|
3.22 KB,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
sayrer
:
approval1.9+
|
Details | Diff | Splinter Review |
If we ResumeAt from 0, the server can realize it's going to be a full response and just send 200 back instead of 206. We should just accept the 200 response instead of only allowing 206 if we're resuming from 0.
Updated resumable channel testcase accordingly.
Attachment #282894 -
Flags: superreview?(cbiesinger)
Attachment #282894 -
Flags: review?(cbiesinger)
|
||
Updated•17 years ago
|
Attachment #282894 -
Flags: superreview?(cbiesinger)
Attachment #282894 -
Flags: superreview+
Attachment #282894 -
Flags: review?(cbiesinger)
Attachment #282894 -
Flags: review+
|
Assignee | |
Comment 1•17 years ago
|
||
Comment on attachment 282894 [details] [diff] [review]
v1
a1.9?
This would be nice to have incase servers choose not to support resuming but we happen to be resuming from 0.
Attachment #282894 -
Flags: approval1.9?
|
|
Assignee | |
Comment 2•17 years ago
|
||
Fix the resumable channel test to correctly respond to Range requests with 206 -- not only when it's sending partial content.
Attachment #282894 -
Attachment is obsolete: true
Attachment #282896 -
Flags: superreview?(cbiesinger)
Attachment #282896 -
Flags: review?(cbiesinger)
Attachment #282894 -
Flags: approval1.9?
|
|
||
Updated•17 years ago
|
Attachment #282896 -
Flags: superreview?(cbiesinger)
Attachment #282896 -
Flags: superreview+
Attachment #282896 -
Flags: review?(cbiesinger)
Attachment #282896 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #282896 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #282896 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v <-- nsHttpChannel.cpp
new revision: 1.322; previous revision: 1.321
done
Checking in netwerk/test/unit/test_resumable_channel.js;
/cvsroot/mozilla/netwerk/test/unit/test_resumable_channel.js,v <-- test_resumable_channel.js
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
You need to log in
before you can comment on or make changes to this bug.
Description
•