398105 - Removing xlink:href attribute from <svg:a> does not update elements influenced by :link styles

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Testcase based on layout/reftests/svg/pseudo-classes-02.svg (from bug 268135).

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Jesse Ruderman]

Attachment: reference

Comment 3

[Robert Longson [:longsonr]]

This is invalid, you can't use removeAttribute to remove a namespaced attribute. 

If you use removeAttributeNS it works for me.

onload="setTimeout(function() { document.getElementById('r').removeAttributeNS('http://www.w3.org/1999/xlink','href'); }, 0);"

Comment 4

[Jesse Ruderman]

The attribute does get removed in the testcase.  Look in DOM Inspector, then delete the root element and undo.

Comment 5

[Robert Longson [:longsonr]]

Attachment: testcase with removeAttributeNS

Comment 6

[Robert Longson [:longsonr]]

Attachment: testcase with removeAttributeNS

Comment 7

[Robert Longson [:longsonr]]

Looks like removeAttributeNS doesn't work either despite my previous assertion to the contrary.

Comment 8

[Robert Longson [:longsonr]]

bug 113310 was the html version of this.

Comment 9

[Robert Longson [:longsonr]]

I tried converting the patch from bug 113310 to nsSVGAElement but this did not fix it so I don't really know why this doesn't work.

Comment 10

[Robert Longson [:longsonr]]

Attachment: patch

Comment 11

[Robert Longson [:longsonr]]

Of course I could pass the attribute namespace ID around with the attribute and perhaps that would address the what about XLink comment if made the check be based on href and an attribute xlink namespace. That would require changes to a number of files to pass that information through though.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 287540 [details] [diff] [review]
patch

I guess this works, yeah.  Watch for perf regressions when you land!

Comment 13

[tor]

Comment on attachment 287540 [details] [diff] [review]
patch

As bz said, please land this during a time when the performance can be isolated.

Comment 14

[Robert Longson [:longsonr]]

Seemed quiet. Checked in. 

Comment 15

[Robert Longson [:longsonr]]

Checked in reftest:
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/dynamic-link-style-01.svg