398120 - Omnibus ad-blocking bug for October 2007

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Step right up, get your ad-blocking here....

Comment 1

[Chris Lawson (gone)]

Scientific American has a few ads on their site like this:

http://www.sciam.com/media/promo/0707_subscription-302x174.gif

Not sure if "promo" is too general or not.

There's also an ad for their "piemonte" section, which appears to be a euphemism for "ads":

http://www.sciam.com/piemonte/

Again, not sure if "piemonte" would be too general (or too specific).

Comment 2

[Chris Lawson (gone)]

Ads all over the place here:

http://www.wweek.com/editorial/3348/9693/

Mostly from banners.wweek.com , which may be too obscure for us to worry about, but worth mentioning.

Comment 3

[Stuart Morgan]

From a forum complaint about drudgereport, it looks like we can block images from mercuras.com.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

And/or a:link[href*="adgardener.com"] img

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://www.osweekly.com/index.php?option=com_content&task=view&id=2677&Itemid=449

Images from http://images.industrybrains.com/banner/ (seems like an ad-server)

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> There's also an ad for their "piemonte" section, which appears to be a
> euphemism for "ads":

No, that's their euphemism for "let's all go visit Marcello" ;)

Comment 7

[philippe (part-time)]

the Beep for non-UK users.
news.bbc.co.uk

@-moz-document domain(news.bbc.co.uk) {
div[id*='ad'][class*='ad'] {display:none !important;}
}

Atm, I only get one ad in the left-hand sidebar on the front page.
The ad itself is blocked (fffflash from doubleclick), but leaves a ~300px tall gap in the column (ad is wrapped in a div with width + height set).
The code eliminates that gap, and at least two others instances that are in the source code but not yet visible (one wide one at the top and a tall one on the right).

BTW, this give strange effects on trunk. When the front-page loads, those empty places are visible, but collapse when loaded. I see the same with the latest WebKit builds.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

> @-moz-document domain(news.bbc.co.uk) {
> div[id*='ad'][class*='ad'] {display:none !important;}
> }

I think I'd like to do div[id^="ad"][class^="ad"] and not wrap that in a bbc block.

(In reply to comment #1)
> Not sure if "promo" is too general or not.

I think it's too vague; at least in my mind, "promo" does not always equal "advertising"

(In reply to comment #2)
> Mostly from banners.wweek.com, which may be too obscure for us to worry 

That's too specific/obscure, and "banners" is way too vague.

Comment 9

[Stuart Morgan]

(In reply to comment #8)
> I think I'd like to do div[id^="ad"][class^="ad"] and not wrap that in a bbc
> block.

Why not just ="ad"? Lots of words start with "ad".

Comment 10

[philippe (part-time)]

(In reply to comment #9)
> (In reply to comment #8)
> > I think I'd like to do div[id^="ad"][class^="ad"] and not wrap that in a bbc
> > block.
> 
> Why not just ="ad"? Lots of words start with "ad".
> 

Because the ID's and classes are actually:
<div id="ad4" class="ad4"></div>
<div id="ad3" class="ad3closed"></div>
etc

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Stuart and I discussed this in the channel, and we decided

div[id^="ad1"], 
div[id^="ad2"], 
etc.

is probably a more effective way of dealing with this, and gets us <div id="ad169_full_of_ads"> for free while sparing us false positives from <div id="address1" class="address"> and so forth.

Comment 12

[philippe (part-time)]

(In reply to comment #11)
> Stuart and I discussed this in the channel, and we decided
> 
> div[id^="ad1"], 
> div[id^="ad2"], 
> etc.

That will probably work fine, at least: no false positives in one hour of random surfing.
For the BBC -at time of writing - you'll need ad1, ad2, ad3, ad4

-----------

The new Gmail interface
The ads in the right-hand column are now wrapped in
div.slwyWc (exact match)
(at least on my side, with both the latest BonEcho and Camino Trunk, Gmail set to use text/plain).

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: October 2007 Omnibus ads

This adds everything mentioned except the aforementioned vague/multiple meanings items in comment 8.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the trunk and MOZILLA_1_8_BRANCH.

Nominating for 1.5.4 (depending on when we do it)

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

1.5.4 is coming too soon for this; let's do 1.5.5.

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We've heard nothing bad about these changes, so...checked in on the CAMINO_1_5_BRANCH for 1.5.5.