398174 - browser.download.manager.addToRecentDocs is not set by default

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect, P3)

Description

[Shawn Wilsher :sdwilsh]

We want this to be set to true by default as per conversation with mconnor.

requesting wanted-fx3

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

For QA's benefit--meaning me, currently--please describe what this pref is, and how to test it; thanks!

Comment 2

[Shawn Wilsher :sdwilsh]

It will add the download to the "recent documents" thing in windows

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Actually, now that I actually look at the code... we default "addToRecentDocs" to true, so the pref is only there to optionally disable the feature. I suppose we should add it to firefox.js, but that probably makes this un-wanted-firefox3.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: add default pref, comment

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 283355 [details] [diff] [review]
add default pref, comment

heh, well, if its actually enabled... :)  we still want this I think.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/app/profile/firefox.js 	1.205
mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp 	1.134

Comment 7

[Jim Jeffery not reading bug-mail 1/2/11]

This appears to not be working on Vista HP.  I've downloaded several files today and so far none are showing up in the 'Recent Items' list. 

Note:  Recent Items is most likely different the 'Recent Docs' used by XP.  

Yes I have the latest build, and I've checked the pref, and its set to 'true'

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007100311 Minefield/3.0a9pre Firefox/3.0 ID:2007100311

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #7)
> This appears to not be working on Vista HP.  I've downloaded several files
> today and so far none are showing up in the 'Recent Items' list. 

Is it possible they're all .exes? The function we call to add items to "recent documents" ignores executables.

In any case, your first step when discovering this kind of issue should be to file a new bug, instead of commenting on an existing unrelated one :) INVALID bugs are cheaper than bugs that get lost because they're only mentioned in a comment on a FIXED bug.

Comment 9

[Jim Jeffery not reading bug-mail 1/2/11]

Thanks gavin, yes.. they were .exe's 

Will remember next time and just file a bug.  

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Tested with tinderbox builds from
ftp://ftp.mozilla.org/pub/firefox/tinderbox-builds/FX-WIN32-TBOX-trunk of:

Windows XP SP 2 - Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre)
Gecko/2007103017 Minefield/3.0a9pre

and Vista - Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre)
Gecko/2007103017 Minefield/3.0a9pre

This works like a charm, now; in Vista, just setting the Start Menu style to
"classic" makes the fix apparent.

Verified FIXED

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Just so I don't go insane, the other bug I spun off from this was bug 401430.

https://litmus.mozilla.org/show_test.cgi?id=5148

in-litmus+