398197 - Canceled queued downloads come from Wed, Dec 31, 1969 6:00 PM

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Attachment: canceled queued download

Seems like this is difficult to test without bug 393821 to actually have queued downloads show up. (Some reason trunk doesn't show queued downloads, but bug 393821 fixes that.)

1. Start a bunch of downloads that end up queued
2. Cancel a queued download
3. Check information

Comment 1

[Ed Lee :Mardak]

Ergh. ? Removing depends. Seems like it can show up without the bug. For those curious, alt-click (save file) on a bunch of the mp3 links from http://courses.ece.uiuc.edu/ece498/al1/Syllabus.html

Comment 2

[Ed Lee :Mardak]

Attachment: v1

Set the time when we add the download as if we were given a correct time instead of just 0.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 283065 [details] [diff] [review]
v1

r=sdwilsh

Comment 4

[Ed Lee :Mardak]

Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
/cvsroot/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp,v  <--  nsDownloadManager.cpp
new revision: 1.127; previous revision: 1.126
done

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

Timestamps are correct using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007103103 Minefield/3.0a9pre

and 

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9a9pre) Gecko/2007103104 Minefield/3.0a9pre, with the testcase from comment 1; cancelling queued downloads, and then clicking on their information icon yields the correct time at which they were cancelled.