398234 - Exception in nsIDownloadManager.cancelDownload when trying to cancel 'stuck' download

Status: VERIFIED WORKSFORME

(Toolkit :: Downloads API, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a9pre) Gecko/2007100120 Minefield/3.0a9pre (but this has been happening for a while).

Summary: Exception in nsIDownloadManager.cancelDownload when trying to cancel 'stuck' download

Steps to Reproduce:

1. I *think* I reproduced a bunch of ghost entries by forcing Firefox to quit, to simulate crashes, while downloading ISO files.
2. Try to cancel these downloads upon restart.

Expected Results:

Downloads are cancelled, and then can be removed/cleared from the list.

Actual Results:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDownloadManager.cancelDownload]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://mozapps/content/downloads/downloads.js :: cancelDownload :: line 193"  data: no]

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Downloads.sqlite file

Comment 2

[Ed Lee :Mardak]

Ah, didn't realize this was from crashing the browser or something along those lines. Download manager is probably displaying a download in an inconsistent state -- cancel is likely failing because it's not an active download. Potentially fixed by bug 384810.

Comment 3

[Shawn Wilsher :sdwilsh]

Yeah, so it's not an active download, so it will fail.  This will be fixed by bug 384810 - you could argue that it's even a dupe.

Comment 4

[Shawn Wilsher :sdwilsh]

Stephen - still go this?  I'd hope you don't...

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> Stephen - still go this?  I'd hope you don't...

No; closing it out.  That download-resume/recover code works really well.