Closed Bug 398243 Opened 19 years ago Closed 19 years ago

[FIX]Form controls can be reset on reload

Categories

(Core :: Layout: Form Controls, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smontagu, Assigned: bzbarsky)

References

Details

(Keywords: regression)

Attachments

(3 files, 1 obsolete file)

Attached file testcase —
I'm not 100% if I understand the exact circumstances where this happens, but something like this: if a page contains form controls not inside a <form>, then on reload only the first control on the page retains its state, and all the others are reset. Because it doesn't happen in a <form>, this might not seem like a blocker at first sight, but it's a regression, and it might also be a symptom of something more serious.
Flags: blocking1.9?
Regression range is from 2006-06-07-05 to 2006-06-08-05. Bug 336062?
Attached patch Fix — — Splinter Review
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #283245 - Flags: superreview?(jst)
Attachment #283245 - Flags: review?(jst)
Simon, do you have regression tests for this (as part of your work on that other bug)?
Blocks: 336062
Summary: Form controls can be reset on reload → [FIX]Form controls can be reset on reload
Attachment #283245 - Flags: superreview?(jst)
Attachment #283245 - Flags: superreview+
Attachment #283245 - Flags: review?(jst)
Attachment #283245 - Flags: review+
Attachment #283245 - Flags: approval1.9+
Fix checked in. Still need tests....
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Flags: blocking1.9? → in-testsuite?
Resolution: --- → FIXED
Yeah, I can easily adapt tests that I've already written to cover this. Would content/base/test/ be the right place to put them?
That would be the right place, yes.
Attached patch Test (obsolete) — — Splinter Review
Hmm. Can't we do it with an iframe and location.reload() in pure mochitest, so it doesn't depend on the Firefox UI to work?
Attached patch pure mochitest — — Splinter Review
Attachment #283603 - Attachment is obsolete: true
That looks lovely! I tweaked it to not have a race between the timeout and the reload, and checked it in. Simon, thank you for creating the test!
Flags: in-testsuite? → in-testsuite+
Depends on: 404418
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: