398243 - [FIX]Form controls can be reset on reload

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Simon Montagu :smontagu]

Attachment: testcase

I'm not 100% if I understand the exact circumstances where this happens, but something like this: if a page contains form controls not inside a <form>, then on reload only the first control on the page retains its state, and all the others are reset.

Because it doesn't happen in a <form>, this might not seem like a blocker at first sight, but it's a regression, and it might also be a symptom of something more serious.

Comment 1

[Simon Montagu :smontagu]

Regression range is from 2006-06-07-05 to 2006-06-08-05. Bug 336062?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 3

[Boris Zbarsky [:bzbarsky]]

Simon, do you have regression tests for this (as part of your work on that other bug)?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fix checked in.  Still need tests....

Comment 5

[Simon Montagu :smontagu]

Yeah, I can easily adapt tests that I've already written to cover this. Would content/base/test/ be the right place to put them?

Comment 6

[Boris Zbarsky [:bzbarsky]]

That would be the right place, yes.

Comment 7

[Simon Montagu :smontagu]

Attachment: Test

Comment 8

[Boris Zbarsky [:bzbarsky]]

Hmm.  Can't we do it with an iframe and location.reload() in pure mochitest, so it doesn't depend on the Firefox UI to work?

Comment 9

[Simon Montagu :smontagu]

Attachment: pure mochitest

Comment 10

[Boris Zbarsky [:bzbarsky]]

That looks lovely!  I tweaked it to not have a race between the timeout and the reload, and checked it in.  Simon, thank you for creating the test!