398337 - tweak bidi reftests

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

[oops, accidentally hit enter in the assignee textfield so filed blank]

A bunch of the bidi reftests don't pass for me:
 * 000 fails because the text wraps to multiple lines.
 * 006 fails because the U+05D9 character in my 36pt Hebrew font is wider than 9pt, so it gets cut off in the overflow:hidden case

I have a patch that:
 * converts all the measurements in the bidi reftests from pt to px, since the window the tests run in is sized in px

 * rewrites the 006 test so that it tightly wraps the character with inline-blocks from the following line, spaced around the same character without a diacritic (This means it assumes the diacritic is narrower than the character, which is hopefully ok.)

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Note that this changes the line endings on 006* (which were somehow checked in with Windows line endings), but since the file is changed drastically enough already I'm not sure of the value of a whitespace-ignoring diff.

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 283277 [details] [diff] [review]
patch

> This means it assumes the diacritic is narrower than the
> character, which is hopefully ok.)

That assumption doesn't hold on my default sans-serif Hebrew font. I suggest changing the base character from U+05D9 to U+05D6, which should be no less wide than the diacritic, but not so wide that there's a chance that the diacritic could be misplaced without overhanging. r=me with that change.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Checked in with that change.