Closed Bug 398348 Opened 17 years ago Closed 14 years ago

Spell check language selection uses check marks instead of radio buttons

Categories

(Toolkit :: UI Widgets, defect)

Product:
Toolkit
Component:
UI Widgets
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b1

People

(Reporter: bmarsd, Assigned: bmarsd)

References

Details

Attachments

(1 file, 1 obsolete file)

patch updated to trunk
1.29 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007100204 Minefield/3.0a9pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007100204 Minefield/3.0a9pre

In the spell check languages context menu, languages appear with check boxes next to them. Because you can only select one language at a time, they should use radio buttons instead.

Reproducible: Always

Steps to Reproduce:
1. Right click a form being spell checked
2. Open the "Languages" context menu
Confirming this issue. Current behaviour is inconsistent with all user interface guidelines.
Component: General → XUL Widgets
Product: Firefox → Toolkit
Version: unspecified → Trunk
Attached patch Patch (obsolete) — — Splinter Review 
Really trivial patch
QA Contact: general → xul.widgets
Blocks: 557621
Attachment #384255 - Flags: review?(gavin.sharp)
Comment on attachment 384255 [details] [diff] [review]
Patch

This change now needs to be made to toolkit/content/InlineSpellChecker.jsm, but the same patch applies.
Attachment #384255 - Flags: review?(gavin.sharp) → review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → bmarsd
Keywords: checkin-needed

        Attachment #384255 -
        Attachment is obsolete: true

        Attachment #450999 -
        Flags: review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/e27b8a99d73b
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5

    
  
Target Milestone: mozilla1.9.3a5 → mozilla1.9.3a6

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: