398388 - XUL numberboxes for the Print Preview

Status: RESOLVED FIXED

(Toolkit :: Printing, defect)

Description

[Takeshi Kurosawa :takenspc]

Attachment: Patch for Print Dialog and Print Preview

UL textboxes of print related dialogs which accept only integer should use type="number". And we can drop or simplify some functions

Comment 1

[Takeshi Kurosawa :takenspc]

Attachment: Screenshot with the patch

Comment 2

[Takeshi Kurosawa :takenspc]

Comment on attachment 283339 [details] [diff] [review]
Patch for Print Dialog and Print Preview

Gavin, could you review this patch?

Comment 3

[Reed Loden [:reed]]

How much does this matter now that the XUL printing dialog has been dropped for Linux? It's only used on Windows now... Will this patch still help Windows?

Comment 4

[Takeshi Kurosawa :takenspc]

(In reply to comment #3)
> How much does this matter now that the XUL printing dialog has been dropped for
> Linux? It's only used on Windows now... Will this patch still help Windows?
> 

Ah! XUL printing dialog seems dead on all platform.
But Print Preview is still alive and can be cleaned up by using numberbox.

Comment 5

[Takeshi Kurosawa :takenspc]

Attachment: Patch for Print Preview

There is no visual changes. There is only code cleaning up.

Comment 6

[Takeshi Kurosawa :takenspc]

Comment on attachment 303661 [details] [diff] [review]
Patch for Print Preview

Sorry, I forgot setting the review flag :-(.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 303661 [details] [diff] [review]
Patch for Print Preview

Sorry for the unreasonable delay here...

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: updated patch

Just updates the patch for a minor context change so that it applies cleanly.

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/fcf5834e1b6a