Cleanup remaining uses of nsIBadCertListener in Toolkit

RESOLVED FIXED in mozilla1.9beta1

Status

RESOLVED FIXED
11 years ago
2 years ago

People

(Reporter: kaie, Assigned: dveditz)

Tracking

Trunk
mozilla1.9beta1
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
This morning I landed bug 327181. As part of this I removed nsIBadCertListener.

Afterwards I did another search for this interface across our sources and I realized I missed something in toolkit:



mozilla/toolkit/mozapps/shared/src/badCertHandler.js: * This class implements nsIBadCertListener.  It's job is to prevent "bad cert"
mozilla/toolkit/mozapps/shared/src/badCertHandler.js:    if (!iid.equals(Components.interfaces.nsIBadCertListener) &&

mozilla/toolkit/mozapps/update/src/nsUpdateService.js.in:    this._request.channel.notificationCallbacks = new BadCertHandler();
mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in:    request.channel.notificationCallbacks = new BadCertHandler();
mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in:      // BadCertHandler would prevent getting this far). Update checks will
mozilla/toolkit/mozapps/extensions/src/nsBlocklistService.js:    request.channel.notificationCallbacks = new BadCertHandler();
mozilla/toolkit/mozapps/shared/src/badCertHandler.js:function BadCertHandler() {
mozilla/toolkit/mozapps/shared/src/badCertHandler.js:BadCertHandler.prototype = {

This code will probably trigger a runtime JS exception, because the interface reference from JS is gone.

As an immediate fix, I'll attach a patch that removes the interface reference.

Next we should verify whether the BadCertHandler can go away completely.
Flags: blocking1.9?
(Reporter)

Comment 1

11 years ago
Created attachment 283359 [details] [diff] [review]
Patch v1
Attachment #283359 - Flags: review?(mconnor)
Attachment #283359 - Flags: approval1.9?
(Reporter)

Updated

11 years ago
Summary: Cleanup remaining uses of nsIBadCertListener → Cleanup remaining uses of nsIBadCertListener in Toolkit

Updated

11 years ago
Attachment #283359 - Flags: review?(mconnor)
Attachment #283359 - Flags: review+
Attachment #283359 - Flags: approval1.9?
Attachment #283359 - Flags: approval1.9+
(Reporter)

Comment 2

11 years ago
fixed
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Flags: blocking1.9? → blocking1.9+
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.