398566 - Set MOZ_FIX_LINK_PATHS unconditionally

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

Attachment: use MOZ_FIX_LINK_PATHS unconditionally, rev. 1

For mozilla2 stuff I'm changing the linkage hierarchy a little bit and we're always going to need MOZ_FIX_LINK_PATHS... and I can't see any reason why we shouldn't just always add MOZ_FIX_LINK_PATHS to LDFLAGS instead of specifying it in a bunch of different directories (and sometimes forgetting it).

I'd like this reviewed for mozilla-central at least, but I don't see any reason we can't land it in 1.9 right now.

Comment 1

[Benjamin Smedberg]

Comment on attachment 283561 [details] [diff] [review]
use MOZ_FIX_LINK_PATHS unconditionally, rev. 1

This is very low-risk: if it compiles correctly, it's fine.

Comment 2

[Benjamin Smedberg]

Fixed on CVS trunk for 1.9

Comment 3

[Eric Hattemer]

I'm fairly sure this commit is why firefox 2.0.0.11 won't compile on my solaris 9 with gcc and solaris ld:

c++ -I/usr/openwin/include -fno-rtti -fno-exceptions -Wno-long-long -pedantic -fshort-wchar -pthreads -pipe  -DNDEBUG -DTRIMMED -O3 -fPIC -G -Wl,-h,libxpcom.so -o libxpcom.so  nsXPComStub.o       -L../../dist/bin -L../../dist/lib -Wl,-rpath-link,../../dist/bin -lxpcom_core -L../../dist/lib -lplds4 -lplc4 -lnspr4 -ldl -lrt -lsocket -ldl -lm
ld: fatal: option -dn and -h are incompatible
ld: fatal: option -dn and -P are incompatible
ld: fatal: option -dn and -G are incompatible
ld: fatal: Flags processing errors
collect2: ld returned 1 exit status
gmake[3]: *** [libxpcom.so] Error 1
gmake[3]: Leaving directory `/auto/src-02/common/usc/firebird/2.0.0.11/xpcom/stub'

In my case, changing -Wl,-rpath-link,../../dist/bin to -R../../dist/bin was able to compile that file.

Comment 4

[Benjamin Smedberg]

You should file (or find) a bug on this issue and provide a patch.