Closed
Bug 398566
Opened 14 years ago
Closed 14 years ago
Set MOZ_FIX_LINK_PATHS unconditionally
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
Details
Attachments
(1 file)
2.91 KB,
patch
|
ted
:
review+
sayrer
:
approval1.9+
|
Details | Diff | Splinter Review |
For mozilla2 stuff I'm changing the linkage hierarchy a little bit and we're always going to need MOZ_FIX_LINK_PATHS... and I can't see any reason why we shouldn't just always add MOZ_FIX_LINK_PATHS to LDFLAGS instead of specifying it in a bunch of different directories (and sometimes forgetting it). I'd like this reviewed for mozilla-central at least, but I don't see any reason we can't land it in 1.9 right now.
Attachment #283561 -
Flags: review?(ted.mielczarek)
Updated•14 years ago
|
Attachment #283561 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 1•14 years ago
|
||
Comment on attachment 283561 [details] [diff] [review] use MOZ_FIX_LINK_PATHS unconditionally, rev. 1 This is very low-risk: if it compiles correctly, it's fine.
Attachment #283561 -
Flags: approval1.9?
Updated•14 years ago
|
Attachment #283561 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 2•14 years ago
|
||
Fixed on CVS trunk for 1.9
Assignee | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 3•13 years ago
|
||
I'm fairly sure this commit is why firefox 2.0.0.11 won't compile on my solaris 9 with gcc and solaris ld: c++ -I/usr/openwin/include -fno-rtti -fno-exceptions -Wno-long-long -pedantic -fshort-wchar -pthreads -pipe -DNDEBUG -DTRIMMED -O3 -fPIC -G -Wl,-h,libxpcom.so -o libxpcom.so nsXPComStub.o -L../../dist/bin -L../../dist/lib -Wl,-rpath-link,../../dist/bin -lxpcom_core -L../../dist/lib -lplds4 -lplc4 -lnspr4 -ldl -lrt -lsocket -ldl -lm ld: fatal: option -dn and -h are incompatible ld: fatal: option -dn and -P are incompatible ld: fatal: option -dn and -G are incompatible ld: fatal: Flags processing errors collect2: ld returned 1 exit status gmake[3]: *** [libxpcom.so] Error 1 gmake[3]: Leaving directory `/auto/src-02/common/usc/firebird/2.0.0.11/xpcom/stub' In my case, changing -Wl,-rpath-link,../../dist/bin to -R../../dist/bin was able to compile that file.
Assignee | ||
Comment 4•13 years ago
|
||
You should file (or find) a bug on this issue and provide a patch.
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•