398568 - PRBool misuse bugs in netwerk/

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[(dormant account)]

Attachment: PRbool fixes

This is the automatic patch produced by prcheck. The misuse in netwerk is relatively harmless compared to other modules.

Comment 1

[(dormant account)]

Attachment: PRBool fixes, take 2

Updated patch to use !!. Took out the problematic hunk for now:
--- netwerk/base/src/nsLoadGroup.cpp	18 Jul 2007 21:37:40 -0000	1.73
+++ netwerk/base/src/nsLoadGroup.cpp	4 Oct 2007 17:03:39 -0000
@@ -708,17 +708,17 @@ nsLoadGroup::RemoveRequest(nsIRequest *r
 // hash to an nsISupportsArray.
 PR_STATIC_CALLBACK(PLDHashOperator)
 AppendRequestsToISupportsArray(PLDHashTable *table, PLDHashEntryHdr *hdr,
                                PRUint32 number, void *arg)
 {
     RequestMapEntry *e = static_cast<RequestMapEntry *>(hdr);
     nsISupportsArray *array = static_cast<nsISupportsArray *>(arg);
 
-    PRBool ok = array->AppendElement(e->mKey);
+    PRBool ok = !!array->AppendElement(e->mKey);
 
     if (!ok) {
         return PL_DHASH_STOP;
     }
 
     return PL_DHASH_NEXT;
 }

Comment 2

[(dormant account)]

The problem is that nsISupportsArray inherits from nsICollection which specifies AppendElement as returning nsresult.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 283757 [details] [diff] [review]
PRBool fixes, take 2

I preferred 0 !=...

Comment 4

[(dormant account)]

Attachment: PRBool fixes, take 3

Same as original patch but without the AppendElement() issue.
Note that this would be the only patch in the series to use 0 !=.

Comment 5

[(dormant account)]

Christian, 
Can you review the patch?

Comment 6

[Damon Sicore (:damons)]

Comment on attachment 284176 [details] [diff] [review]
PRBool fixes, take 3

a1.9+=damons

Comment 7

[(dormant account)]

Checking in netwerk/cache/src/nsCacheRequest.h;
/cvsroot/mozilla/netwerk/cache/src/nsCacheRequest.h,v  <--  nsCacheRequest.h
new revision: 1.19; previous revision: 1.18
done
Checking in netwerk/cache/src/nsCacheSession.h;
/cvsroot/mozilla/netwerk/cache/src/nsCacheSession.h,v  <--  nsCacheSession.h
new revision: 1.6; previous revision: 1.5
done
Checking in netwerk/cache/src/nsDiskCacheMap.h;
/cvsroot/mozilla/netwerk/cache/src/nsDiskCacheMap.h,v  <--  nsDiskCacheMap.h
new revision: 1.20; previous revision: 1.19
done
Checking in netwerk/cookie/src/nsCookieService.cpp;
/cvsroot/mozilla/netwerk/cookie/src/nsCookieService.cpp,v  <--  nsCookieService.cpp
new revision: 1.87; previous revision: 1.86
done
Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <--  nsHttpChannel.cpp
new revision: 1.327; previous revision: 1.326
done
Checking in netwerk/streamconv/converters/mozTXTToHTMLConv.cpp;
/cvsroot/mozilla/netwerk/streamconv/converters/mozTXTToHTMLConv.cpp,v  <--  mozTXTToHTMLConv.cpp
new revision: 1.87; previous revision: 1.86
done