Closed
Bug 398599
Opened 18 years ago
Closed 18 years ago
PRBool misuse bugs in embedding/
Categories
(Core Graveyard :: Embedding: GTK Widget, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
8.51 KB,
patch
|
benjamin
:
review+
sayrer
:
approval1.9+
|
Details | Diff | Splinter Review |
These are a mix of manual fixes and automatic rewrites of prbool bugs found by prcheck.
This is a little uglier than usual due to values coming from outside of gecko, so more values have to be checked.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #283598 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 2•18 years ago
|
||
Switched from 0 != to !!
Attachment #283598 -
Attachment is obsolete: true
Attachment #283786 -
Flags: review?(benjamin)
Attachment #283598 -
Flags: review?(benjamin)
|
||
Updated•18 years ago
|
Attachment #283786 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #283786 -
Flags: approval1.9?
|
||
Updated•18 years ago
|
Attachment #283786 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Committed
embedding/browser/gtk/src/EmbedContentListener.cpp
embedding/browser/gtk/src/EmbedGlobalHistory.cpp
embedding/browser/gtk/src/GtkPromptService.cpp
embedding/browser/gtk/src/gtkmozembed2.cpp
embedding/browser/webBrowser/nsContextMenuInfo.cpp
embedding/browser/webBrowser/nsWebBrowser.cpp
embedding/components/windowwatcher/src/nsPromptService.cpp
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•