Closed
Bug 398619
Opened 18 years ago
Closed 18 years ago
Change cleanup to "Clear List"
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
VERIFIED
FIXED
mozilla1.9beta1
People
(Reporter: sdwilsh, Assigned: Mardak)
References
Details
As per our new UI, we need to change strings that say cleanup to be clear list. I'd also like to see the command and menuitem id's change accordingly (and any code that goes along with for the UI - the back-end API is fine with cleanup).
Flags: blocking-firefox3?
Comment 1•18 years ago
|
||
Sure, I could try to do this as soon as bug 391863 gets approved and checked in.
Assignee: nobody → martijn.martijn
Acording to http://people.mozilla.com/~madhava/files/downloadmanager/downloadmanager_2007-09-25_revision.png it should be "Remove all from list" and in bug 330139 "remove" is changing to "remove from list".
So are we going to have a "Remove from list" and a "Clear list"?
Comment 3•18 years ago
|
||
The strings should be as per the mockup in bug 330139, so "Remove all from list" and "Remove from list", not "Clear list". Morphing, blocking, yay!
Flags: blocking-firefox3? → blocking-firefox3+
Summary: Change cleanup to clear list → Change cleanup to "Remove all from list"
Assignee | ||
Comment 4•18 years ago
|
||
Changing back to "Clear List" per bug 397655 comment #14 (2007/10/02)
- button- and context menu-text for clearing the list should be the same (d.a.f)
see attachment 283251 [details]
Summary: Change cleanup to "Remove all from list" → Change cleanup to "Clear List"
Assignee | ||
Comment 5•18 years ago
|
||
I'll update the patch for bug 391863 to incorporate Clear List because pretty much for every line that patch touches.. the patch to make this change would touch those same lines.
Assignee: martijn.martijn → edilee
Updated•18 years ago
|
Target Milestone: Firefox 3 M10 → Firefox 3 M11
Assignee | ||
Comment 6•18 years ago
|
||
Fixed by bug 391863.
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: in-testsuite-
Flags: in-litmus?
Resolution: --- → FIXED
Target Milestone: Firefox 3 M11 → Firefox 3 M9
Comment 7•18 years ago
|
||
https://litmus.mozilla.org/show_test.cgi?id=4727
in-litmus+, and verified FIXED, since I'll be verifying the button's string--if we decide to include it--separately.
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus+
Updated•17 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•