PRBool misuse bugs in extensions/pref/

RESOLVED FIXED in mozilla1.9beta1

Status

()

Core
Preferences: Backend
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: (dormant account), Assigned: (dormant account))

Tracking

Trunk
mozilla1.9beta1
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 283628 [details] [diff] [review]
Prbool correction

This was found by prcheck. This is my favourite bug so far. Turned out the function definition didn't match the declaration and some callers called it as it was specified in the definition and some in the declaration.
Attachment #283628 - Flags: review?(bienvenu)

Comment 1

10 years ago
Comment on attachment 283628 [details] [diff] [review]
Prbool correction

Thx for the patch. The other callers (the ones that were wrong) were OK because they passed 0 for both. So if I'm reading this correctly, there's no actual runtime bug, just code that looked wrong...
Attachment #283628 - Flags: review?(bienvenu) → review+
(Assignee)

Updated

10 years ago
Attachment #283628 - Flags: approval1.9?

Updated

10 years ago
Attachment #283628 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 2

10 years ago
Checking in extensions/pref/autoconfig/src/nsReadConfig.cpp;
/cvsroot/mozilla/extensions/pref/autoconfig/src/nsReadConfig.cpp,v  <--  nsReadConfig.cpp
new revision: 1.19; previous revision: 1.18
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Backed out as part of the fun-lovin' Tp-regression-finding game!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Keywords: checkin-needed
Relanded.

Checking in extensions/pref/autoconfig/src/nsReadConfig.cpp;
/cvsroot/mozilla/extensions/pref/autoconfig/src/nsReadConfig.cpp,v  <--  nsReadConfig.cpp
new revision: 1.21; previous revision: 1.20
done
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
You need to log in before you can comment on or make changes to this bug.