398699 - DOM Inspector Find Nodes dialog does not have access keys

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[(no longer active)]

Attachment: Add the access keys

DOM Inspector Find Nodes dialog completely lacks access keys.  The attached patch adds access keys to this dialog.

Comment 1

[Alex Vincent [:WeirdAl]]

Looks great to me!  I haven't followed the localization story with DOM-I, though...

Comment 2

[[e-mail]]

Comment on attachment 283695 [details] [diff] [review]
Add the access keys

>   <!ENTITY findNodesByTag.label "Tag">
>+  <!ENTITY findNodesByTag.accesskey "T">
>+  <!ENTITY findNodesByTag.accesskey2 "g">
>   <!ENTITY findNodesByAttr.label "Attr">
>+  <!ENTITY findNodesByAttr.accesskey "A">
>+  <!ENTITY findNodesByAttr.accesskey2 "t">
You're already using T so you'll just have to use r here I'm afraid. I know it's really ugly, but only other solution I can think of is to redesign this dialog to use a menulist or tab control, which I guess needs a new bug report.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 283695 [details] [diff] [review]
Add the access keys

r=sdwilsh, with Neil's comment fixed.

We really just need to redo this whole dialog...

Comment 4

[(no longer active)]

Attachment: Add the access keys (revised)

Fixed Neil's comments in comment 2.

I was not sure if I should go ahead and ask for approval, or ask another review from Shawn...  So I'm taking the safe side.  :-)

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 284137 [details] [diff] [review]
Add the access keys (revised)

You've already got r and sr, so you just need a now.  You might need to move this to another component or bug the drivers to get approval.

Comment 6

[(no longer active)]

(In reply to comment #5)
> You've already got r and sr, so you just need a now.  You might need to move
> this to another component

Hmmm, is there any other component which covers DOM Inspector bugs?

> or bug the drivers to get approval.

OK, you've lost me!  :-)  Who exactly should I bug?

Sorry for showing my ignorance...

Comment 7

[Reed Loden [:reed]]

Checking in extensions/inspector/resources/content/viewers/dom/findDialog.xul;
/cvsroot/mozilla/extensions/inspector/resources/content/viewers/dom/findDialog.xul,v  <--  findDialog.xul
new revision: 1.12; previous revision: 1.11
done
Checking in extensions/inspector/resources/locale/en-US/viewers/dom.dtd;
/cvsroot/mozilla/extensions/inspector/resources/locale/en-US/viewers/dom.dtd,v  <--  dom.dtd
new revision: 1.12; previous revision: 1.11
done

Comment 8

[Reed Loden [:reed]]

Checking in extensions/inspector/resources/content/viewers/dom/findDialog.xul;
/cvsroot/mozilla/extensions/inspector/resources/content/viewers/dom/findDialog.xul,v  <--  findDialog.xul
new revision: 1.12; previous revision: 1.11
done
Checking in extensions/inspector/resources/locale/en-US/viewers/dom.dtd;
/cvsroot/mozilla/extensions/inspector/resources/locale/en-US/viewers/dom.dtd,v  <--  dom.dtd
new revision: 1.12; previous revision: 1.11
done