Closed Bug 398699 Opened 15 years ago Closed 15 years ago

DOM Inspector Find Nodes dialog does not have access keys

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(2 files)

DOM Inspector Find Nodes dialog completely lacks access keys.  The attached patch adds access keys to this dialog.
Attachment #283695 - Flags: superreview?(neil)
Attachment #283695 - Flags: review?(comrade693+bmo)
Target Milestone: --- → mozilla1.9 M9
Looks great to me!  I haven't followed the localization story with DOM-I, though...
Comment on attachment 283695 [details] [diff] [review]
Add the access keys

>   <!ENTITY findNodesByTag.label "Tag">
>+  <!ENTITY findNodesByTag.accesskey "T">
>+  <!ENTITY findNodesByTag.accesskey2 "g">
>   <!ENTITY findNodesByAttr.label "Attr">
>+  <!ENTITY findNodesByAttr.accesskey "A">
>+  <!ENTITY findNodesByAttr.accesskey2 "t">
You're already using T so you'll just have to use r here I'm afraid. I know it's really ugly, but only other solution I can think of is to redesign this dialog to use a menulist or tab control, which I guess needs a new bug report.
Attachment #283695 - Flags: superreview?(neil) → superreview+
Comment on attachment 283695 [details] [diff] [review]
Add the access keys

r=sdwilsh, with Neil's comment fixed.

We really just need to redo this whole dialog...
Attachment #283695 - Flags: review?(comrade693+bmo) → review+
Fixed Neil's comments in comment 2.

I was not sure if I should go ahead and ask for approval, or ask another review from Shawn...  So I'm taking the safe side.  :-)
Attachment #284137 - Flags: review?(comrade693+bmo)
Blocks: accesskey
Comment on attachment 284137 [details] [diff] [review]
Add the access keys (revised)

You've already got r and sr, so you just need a now.  You might need to move this to another component or bug the drivers to get approval.
Attachment #284137 - Flags: review?(comrade693+bmo) → approval1.9?
(In reply to comment #5)
> You've already got r and sr, so you just need a now.  You might need to move
> this to another component

Hmmm, is there any other component which covers DOM Inspector bugs?

> or bug the drivers to get approval.

OK, you've lost me!  :-)  Who exactly should I bug?

Sorry for showing my ignorance...
Attachment #284137 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in extensions/inspector/resources/content/viewers/dom/findDialog.xul;
/cvsroot/mozilla/extensions/inspector/resources/content/viewers/dom/findDialog.xul,v  <--  findDialog.xul
new revision: 1.12; previous revision: 1.11
done
Checking in extensions/inspector/resources/locale/en-US/viewers/dom.dtd;
/cvsroot/mozilla/extensions/inspector/resources/locale/en-US/viewers/dom.dtd,v  <--  dom.dtd
new revision: 1.12; previous revision: 1.11
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: mozilla1.9 M9 → mozilla1.9 M10
Checking in extensions/inspector/resources/content/viewers/dom/findDialog.xul;
/cvsroot/mozilla/extensions/inspector/resources/content/viewers/dom/findDialog.xul,v  <--  findDialog.xul
new revision: 1.12; previous revision: 1.11
done
Checking in extensions/inspector/resources/locale/en-US/viewers/dom.dtd;
/cvsroot/mozilla/extensions/inspector/resources/locale/en-US/viewers/dom.dtd,v  <--  dom.dtd
new revision: 1.12; previous revision: 1.11
done
You need to log in before you can comment on or make changes to this bug.