398700 - DOM Inspector Insert Node dialog does not have access keys

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[(no longer active)]

DOM Inspector Insert Node dialog completely lacks access keys.

Comment 1

[(no longer active)]

Attachment: Add the access keys

Simple patch to add the access keys to the Insert Node dialog.

Comment 2

[[e-mail]]

Comment on attachment 283697 [details] [diff] [review]
Add the access keys

>-	        <label value="&tagName.label;" control="tx_tagName"/>
>+	        <label value="&tagName.label;"
>+                 accesskey="&tagName.accesskey;"
>+                 control="tx_tagName"/>
> 	        <textbox id="tx_tagName" oninput="dialog.toggleAccept()"/>
> 	      </row>
> 	    </rows>
>       <row id="row_text" flex="1">
>-        <label value="&nodeValue.label;" control="tx_nodeValue"/>
>+        <label value="&nodeValue.label;"
>+               accesskey="&nodeValue.accesskey;"
>+               control="tx_nodeValue"/>
Please be consistent in your indentation - the second example here is correct.

>   <!ENTITY nodeType.label "Node Type:">
>+  <!ENTITY nodeType.accesskey "N">
>   <!ENTITY nodeType.element.label "Element">
>   <!ENTITY nodeType.text.label "Text">
>   <!ENTITY namespaceURI.label "Namespace URI:">
>+  <!ENTITY namespaceURI.accesskey "U">
>   <!ENTITY tagName.label "Tag Name:">
>+  <!ENTITY tagName.accesskey "T">
>   <!ENTITY nodeValue.label "Node Value:">
>+  <!ENTITY nodeValue.accesskey "V">
I'm wondering whether we should swap N and T around, but I'll let Shawn answer!

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 283697 [details] [diff] [review]
Add the access keys

(In reply to comment #2)
> I'm wondering whether we should swap N and T around, but I'll let Shawn answer!
Ug, either way works, but I think using N for tagName and T for nodeType is slightly better.

r=sdwilsh with Neil's other comment fixed.

Comment 4

[(no longer active)]

Attachment: Add the access keys (revised)

Fixed Neil's comments in comment 2.

I was not sure if I should go ahead and ask for approval, or ask another review
from Shawn...  So I'm taking the safe side.  :-)

Comment 5

[Reed Loden [:reed]]

Checking in extensions/inspector/resources/content/viewers/dom/insertDialog.xul;
/cvsroot/mozilla/extensions/inspector/resources/content/viewers/dom/insertDialog.xul,v  <--  insertDialog.xul
new revision: 1.2; previous revision: 1.1
done
Checking in extensions/inspector/resources/locale/en-US/viewers/dom.dtd;
/cvsroot/mozilla/extensions/inspector/resources/locale/en-US/viewers/dom.dtd,v  <--  dom.dtd
new revision: 1.13; previous revision: 1.12
done