Closed
Bug 398707
Opened 17 years ago
Closed 17 years ago
whine.pl should use transactions for database interaction
Categories
(Bugzilla :: Whining, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.2
People
(Reporter: emmanuel, Assigned: emmanuel)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1004 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
whine.pl should use bz_start_transaction/bz_commit_transaction instead of bz_lock_tables/bz_unlock_tables.
|
Assignee | |
Updated•17 years ago
|
OS: Linux → All
Hardware: PC → All
|
|
Assignee | |
Comment 1•17 years ago
|
||
Replace bz_lock_tables by bz_start_transaction. Replace bz_unlock_tables by bz_commit_transaction.
|
||
Comment 2•17 years ago
|
||
Comment on attachment 283706 [details] [diff] [review] Replace locks by transactions >+ $dbh->bz_start_transaction('whine_schedules WRITE', bz_start_transaction() takes no argument.
Attachment #283706 -
Flags: review?(mkanat) → review-
|
|
Assignee | |
Comment 3•17 years ago
|
||
Attachment #283706 -
Attachment is obsolete: true
Attachment #283716 -
Flags: review?(mkanat)
|
||
Comment 4•17 years ago
|
||
Comment on attachment 283716 [details] [diff] [review] Once more, having read the documentation this time Looks good to me.
Attachment #283716 -
Flags: review?(mkanat) → review+
|
|
||
Updated•17 years ago
|
Flags: approval+
|
|
||
Updated•17 years ago
|
Target Milestone: --- → Bugzilla 3.2
|
|
||
Comment 5•17 years ago
|
||
Checking in whine.pl; /cvsroot/mozilla/webtools/bugzilla/whine.pl,v <-- whine.pl new revision: 1.34; previous revision: 1.33 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
||
Updated•17 years ago
|
Blocks: bz-transactions
You need to log in
before you can comment on or make changes to this bug.
Description
•