398739 - "Taking a bug" while adding a new attachment locks the bug status forever if the ASSIGNED bug status has been renamed or deleted

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Frédéric Buclin]

When you take a bug while adding a new attachment, attachment.cgi runs:

      my @newvalues = ($user->id, "ASSIGNED", "", 1, $user->login);
      $dbh->do('UPDATE bugs SET delta_ts = ?, ' .
               join(', ', map("$fields[$_] = ?", (0..3))) . ' WHERE bug_id = ?',
               undef, ($timestamp, map($newvalues[$_], (0..3)) , $bugid));

This means the bug status is set to ASSIGNED. But if you renamed or deleted this bug status (from editvalues.cgi), ASSIGNED isn't valid and process_bug.cgi will reject all subsequent changes made against the bug as no bug status transition between the unknown ASSIGNED status and any other status is defined in the workflow.

The reason to mark this bug as a blocker is that the first bug status you would rename is ASSIGNED (to INPROGRESS, ACCEPTED or anything else, based on previous bug reports on b.m.o), so the probability to see such problems is very high.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Max, could you give a quick glance at the patch? Just in case I missed something.

Comment 2

[Max Kanat-Alexander]

Comment on attachment 283840 [details] [diff] [review]
patch, v1

>+++ Bugzilla/Bug.pm	6 Oct 2007 15:52:04 -0000
>@@ -1139,6 +1139,9 @@ sub _check_rep_platform {
> sub _check_resolution {
>     my ($invocant, $resolution) = @_;
>     $resolution = trim($resolution);
>+    # '' is a valid resolution for open bugs.
>+    return '' if !$resolution;
>+
>     check_field('resolution', $resolution);
>     return $resolution;
> }

  Add a clear_resolution sub instead. '' shouldn't be a valid, settable resolution with set_resolution. (This is the r-.)

>+          [% IF bug_statuses.size %]
>+            <label for="takebug">and set the [% terms.bug %] status to</label>

  It shouldn't be "and set the bug to", because what if I'm already assigned the bug but I want to change it to ASSIGNED now that there's a patch?

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
>   Add a clear_resolution sub instead. '' shouldn't be a valid, settable
> resolution with set_resolution. (This is the r-.)

'' *is* a valid resolution, which is in the resolution DB table.


>   It shouldn't be "and set the bug to", because what if I'm already assigned
> the bug but I want to change it to ASSIGNED now that there's a patch?

If the bug is already assigned to you, you don't see this select field at all. That's intentional. So the wording is correct.

Comment 4

[Frédéric Buclin]

Attachment: patch, v2

Implement $bug->clear_resolution() instead of $bug->set_resolution('').

Comment 5

[Max Kanat-Alexander]

Comment on attachment 283942 [details] [diff] [review]
patch, v2

Great! Thank you. :-)

Comment 6

[Frédéric Buclin]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.132; previous revision: 1.131
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.206; previous revision: 1.205
done
Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.33; previous revision: 1.32
done