Created attachment 283769 [details] testcase Loading the testcase triggers: ###!!! ASSERTION: scrollbars should not have been created: 'result.mHorizontal != NS_STYLE_OVERFLOW_VISIBLE && result.mHorizontal != NS_STYLE_OVERFLOW_CLIP && result.mVertical != NS_STYLE_OVERFLOW_VISIBLE && result.mVertical != NS_STYLE_OVERFLOW_CLIP', file /Users/jruderman/trunk/mozilla/layout/generic/nsGfxScrollFrame.cpp, line 1433
Created attachment 283801 [details] [diff] [review] Proposed fix
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Created attachment 283802 [details] [diff] [review] Same as diff -w
This depends on the fix for bug 395623. Once that lands, I'll add this testcase to the first-line reftests too.
Depends on: 395623
Priority: -- → P2
Target Milestone: --- → mozilla1.9 M10
11 years ago
Comment on attachment 283802 [details] [diff] [review] Same as diff -w Trying roc for the review
Just a reminder to please commit this by Monday if you want to get it in before beta. Otherwise, approval1.9+ will be revoked, and you will need to re-request it after M9 if you still want to land the patch. If you would like somebody else to commit this for you, please add the "checkin-needed" keyword.
Reed, see comment 3. This depends on a bug which was a blocker, and hence didn't have approval, and is now stuck in approval limbo. I'd love to get this in for beta, but that bug needs to go in first. If someone else wants to commit this and deal with any resulting fallout (like it not actually fixing this bug on its own, for example, which it doesn't), go for it. I've only tested this patch and thought about it in the context of bug 395623 already having landed.
Comment on attachment 283802 [details] [diff] [review] Same as diff -w Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT. Please re-request approval if needed.
11 years ago
Attachment #283802 - Flags: approval1.9?
Attachment #283802 - Flags: approval1.9? → approval1.9+
Checked in. layout/reftests/first-line/parent-style-1.html tests this.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.