"ASSERTION: scrollbars should not have been created" with block-in-inline, overflow:inherit, and :first-line

RESOLVED FIXED in mozilla1.9beta2

Status

()

Core
Layout
P2
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Jesse Ruderman, Assigned: bz)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla1.9beta2
x86
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

11 years ago
Created attachment 283769 [details]
testcase

Loading the testcase triggers:

###!!! ASSERTION: scrollbars should not have been created: 'result.mHorizontal != NS_STYLE_OVERFLOW_VISIBLE && result.mHorizontal != NS_STYLE_OVERFLOW_CLIP && result.mVertical != NS_STYLE_OVERFLOW_VISIBLE && result.mVertical != NS_STYLE_OVERFLOW_CLIP', file /Users/jruderman/trunk/mozilla/layout/generic/nsGfxScrollFrame.cpp, line 1433
Created attachment 283801 [details] [diff] [review]
Proposed fix
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Created attachment 283802 [details] [diff] [review]
Same as diff -w
Attachment #283802 - Flags: superreview?(dbaron)
Attachment #283802 - Flags: review?(dbaron)
This depends on the fix for bug 395623.  Once that lands, I'll add this testcase to the first-line reftests too.
Depends on: 395623
Priority: -- → P2
Target Milestone: --- → mozilla1.9 M10
Comment on attachment 283802 [details] [diff] [review]
Same as diff -w

Trying roc for the review
Attachment #283802 - Flags: superreview?(roc)
Attachment #283802 - Flags: superreview?(dbaron)
Attachment #283802 - Flags: review?(roc)
Attachment #283802 - Flags: review?(dbaron)
Attachment #283802 - Flags: superreview?(roc)
Attachment #283802 - Flags: superreview+
Attachment #283802 - Flags: review?(roc)
Attachment #283802 - Flags: review+
Attachment #283802 - Flags: approval1.9+
Just a reminder to please commit this by Monday if you want to get it in before beta. Otherwise, approval1.9+ will be revoked, and you will need to re-request it after M9 if you still want to land the patch. If you would like somebody else to commit this for you, please add the "checkin-needed" keyword.
Reed, see comment 3.  This depends on a bug which was a blocker, and hence didn't have approval, and is now stuck in approval limbo.  I'd love to get this in for beta, but that bug needs to go in first.

If someone else wants to commit this and deal with any resulting fallout (like it not actually fixing this bug on its own, for example, which it doesn't), go for it.  I've only tested this patch and thought about it in the context of bug 395623 already having landed.
Comment on attachment 283802 [details] [diff] [review]
Same as diff -w

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.
Attachment #283802 - Flags: approval1.9+
Attachment #283802 - Flags: approval1.9?
Attachment #283802 - Flags: approval1.9? → approval1.9+
Checked in.  layout/reftests/first-line/parent-style-1.html tests this.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Also layout/reftests/first-letter/parent-style-1.html
You need to log in before you can comment on or make changes to this bug.