398896 - New history search hang since 6 Sep 2007

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ria Klaassen (not reading all bugmail)]

Steps to reproduce:

- Create a new profile and paste a places.sqlite in it (if it doesn't succeed with your own places.sqlite I have a specially created example that could be used for this goal)
- Open history sidebar (use default View setting = By Date) and do a search for the word "bonsai". There should be 4 entries in it

Behaviour before 6 Sep: it finds the 4 entries within 1 or 2 seconds.
Current behaviour: it hangs. After one minute I force closed Firefox.

Regression range for this is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1189117620&maxdate=1189120379 
So I think it is caused by by bug 393464.

Comment 1

[Ria Klaassen (not reading all bugmail)]

A test on my husband's vista computer proved that the bug also occurs on faster systems, but less obvious (7 seconds, CPU 75%).

Comment 2

[Dietrich Ayala (:dietrich)]

Ria, this was backed out for 5 days, can you see if you can reproduce during that period?

1.170	mozilla.mano%sent.com	2007-09-15 12:53	 	Bug 393464 - Re-landing tag-search so search-in-folders (bug 384228) and related work could get the same sort of love. patch by dietrich, r=sspitzer, a=mconnor.

1.169	dietrich%mozilla.com	2007-09-10 11:08	 	Bug 393464 Bookmarks manager doesn't search in tags field (reverting)

Comment 3

[Ria Klaassen (not reading all bugmail)]

I tested a 11 Sep 2007 build and indeed, no problem. 

Comment 4

[Dietrich Ayala (:dietrich)]

ok Ria, thanks for checking.

Comment 5

[Dietrich Ayala (:dietrich)]

Attachment: fix

go directly to db. nsNavHistory::URIHasTag() went from 4-6ms to <1ms in my tests. this change is covered by the unit tests for bug 395101, and those still pass w/ this patch.

http://mxr.mozilla.org/seamonkey/source/toolkit/components/places/tests/bookmarks/test_395101.js

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 283965 [details] [diff] [review]
fix

r=sspitzer

Comment 7

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.176; previous revision: 1.175
done
Checking in toolkit/components/places/src/nsNavHistory.h;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.h,v  <--  nsNavHistory.h
new revision: 1.106; previous revision: 1.105
done

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv