399161 - only call gnome_program_init if there is no GnomeProgram yet

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

nsNativeAppSupportsUnix::Start always calls gnome_program_init. However, this is not desirable since if gnome_program_init was called before XRE_main, there already exists a GnomeProgram instance; and calling it again will override the application name to "Gecko". (See also bug 221012.)

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: proposed patch

Comment 2

[Martin Meyer]

Any chance we could just replace the gnome_program_init stuff with xlib code like Havoc suggested? He said there was some code in Metacity you might be able to copy.

http://mail.gnome.org/archives/desktop-devel-list/2007-July/msg00060.html

Comment 3

[Martin Meyer]

Metacity's session management code lives here:

http://svn.gnome.org/viewvc/metacity/trunk/src/session.c?view=markup

I don't really know any of this code so I can't make a patch out of it :-(

Comment 4

[Christian Persch (GNOME) (away; not receiving bug mail)]

(In reply to comment #2)
> Any chance we could just replace the gnome_program_init stuff with xlib code
> like Havoc suggested? He said there was some code in Metacity you might be able
> to copy.

Please file a separate bug for that; this one is strictly for fixing the use of gnome_program_init.

Comment 5

[Reed Loden [:reed]]

Attachment: what I landed

I unbitrotted chpe's patch and landed it.

http://hg.mozilla.org/mozilla-central/rev/57ff981f69f6