Closed Bug 399161 Opened 12 years ago Closed 10 years ago

only call gnome_program_init if there is no GnomeProgram yet

Categories

(Toolkit :: Startup and Profile System, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: chpe, Assigned: chpe)

References

Details

Attachments

(1 file, 1 obsolete file)

nsNativeAppSupportsUnix::Start always calls gnome_program_init. However, this is not desirable since if gnome_program_init was called before XRE_main, there already exists a GnomeProgram instance; and calling it again will override the application name to "Gecko". (See also bug 221012.)
Attached patch proposed patch (obsolete) — Splinter Review
Attachment #284147 - Flags: review?(benjamin)
Any chance we could just replace the gnome_program_init stuff with xlib code like Havoc suggested? He said there was some code in Metacity you might be able to copy.

http://mail.gnome.org/archives/desktop-devel-list/2007-July/msg00060.html
Metacity's session management code lives here:

http://svn.gnome.org/viewvc/metacity/trunk/src/session.c?view=markup

I don't really know any of this code so I can't make a patch out of it :-(
Attachment #284147 - Flags: review?(benjamin) → review+
(In reply to comment #2)
> Any chance we could just replace the gnome_program_init stuff with xlib code
> like Havoc suggested? He said there was some code in Metacity you might be able
> to copy.

Please file a separate bug for that; this one is strictly for fixing the use of gnome_program_init.
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup
Assignee: nobody → chpe
Attached patch what I landedSplinter Review
I unbitrotted chpe's patch and landed it.

http://hg.mozilla.org/mozilla-central/rev/57ff981f69f6
Attachment #284147 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.