399185 - [FIX]Mark image URIs as immutable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

This should help with bug 389188, since the principal won't need to clone the URI.  Plus, we don't want these URIs changing in any case.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 284164 [details] [diff] [review]
Fix

hrm, I'm not sure that you should set the caller-provided URI to immutable... perhaps the caller should do that?

Comment 2

[Boris Zbarsky [:bzbarsky]]

I suppose I could push this out into the main callers (image loading content and style system).  Would you prefer that?

The more I think about it, the more I wish that all our URI objects were always immutable, with setters returning a modified clone.  :(   Maybe for mozilla2.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Yeah, I'd prefer that.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Do it in the caller

The callers of this method are style system (which is fine with making the URI immutable), some callers that create the URI just before passing it in, and nsImageLoadingContent (which is also fine with the URI being immutable).

Comment 5

[Stuart Parmenter]

this blocks a blocker.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 284862 [details] [diff] [review]
Do it in the caller

a=19drivers for M9

Comment 7

[Boris Zbarsky [:bzbarsky]]

Checked in.