3992 - 'height' style property does not work with TABLE, TR, TBODY, THEAD or TFOOT elements. It DOES work with TD element

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect, P2)

Description

[Christine Hoffman]

Using 3/18 build on Win 95, Win 98, Win NT, Mac8.5 and Linux.

The following test cases demonstrate the problem:

TABLE: http://slip/projects/marvin/bugs/table_height.html (does not work)
TD: http://slip/projects/marvin/bugs/td_height.html (OK - works fine)
TR: http://slip/projects/marvin/bugs/tr_height.html (does not work)
TBODY: http://slip/projects/marvin/bugs/tbody_height.html (does not work)
THEAD: http://slip/projects/marvin/bugs/thead_height.html (does not work)
TFOOT: http://slip/projects/marvin/bugs/tfoot_height.html (does not work)

In the test cases above, a height value of 80pt has been assigned to the
individual element indicated.

NOTE - will write up as a separate bug: The 'height' property value assigned to
the TABLE element behaves differently on different platforms.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The CSS2 rules on the height property in tables are at:

http://www.w3.org/TR/REC-CSS2/tables.html#height-layout

I don't think the spec says anything about handling height on table-row-group,
table-footer-group, or table-header-group

Comment 2

[karnaze (gone)]

Moving to M7.

Comment 3

[Daniel Roberts]

The given test case URLs do not work for me.  Are there alternatives??  BTW,
this bug still seems to be set for M6, though the last comment says it would be
in M7...

Comment 4

[karnaze (gone)]

Moving to M8.

Comment 5

[Christine Hoffman]

Attachment: Attaching the 'TABLE' element test case for external view

Comment 6

[ekrock's old account (dead)]

Marked with [TESTCASE].

Comment 7

[Hixie (not reading bugmail)]

I'm marking this {css2}, because although 'height' is in CSS1, tables are not.
Implementing this correctly involves using the CSS2 definitions.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think height is working on TABLE, but not TR.  It's hard to tell in the
testcase, because 80pt is not much bigger than the height it would otherwise
get.  Perhaps the testcases should be revised.

The correct behavior when multiple heights (or widths) are specified is probably
quite complicated - and height and width on many table elements should be taken
as min-height or min-width (depending on the situation, especially for height).

Comment 9

[karnaze (gone)]

Moving to M9.

Comment 10

[Christine Hoffman]

Attachment: Test case for TD element (this works)

Comment 11

[Christine Hoffman]

Attachment: Test case for TR element (this doesn't work - same for TABLE, THEAD, TBODY, TFOOT)

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See http://www.fas.harvard.edu/~dbaron/css/test/sec170503 for additional test
cases.  Bug 2886 (with fix attached) and bug 10207 also cause problems on that
page.

Comment 13

[karnaze (gone)]

mass move to m14.

Comment 14

[Hixie (not reading bugmail)]

Migrating from {css2} to css2 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
I am *really* sorry about the spam...

Comment 15

[ekrock's old account (dead)]

Bulk moving [testcase] code to new testcase keyword. Sorry for the spam!

Comment 16

[Christine Hoffman]

Adding 'beta1' keyword. 

Comment 17

[rickg]

Marking PDT- because it's CSS2.

Comment 18

[karnaze (gone)]

mass move to m16

Comment 19

[fantasai]

Heights and widths don't work on table cells, either, when they are less than 
the contents' dimensions.

Comment 20

[fantasai]

Attachment: Test: Table Cell Height/Width Less Than Content

Comment 21

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That's certainly the way it should work for 'width', and probably for 'height'
as well.  See http://www.w3.org/TR/REC-CSS2/tables.html#auto-table-layout . 
Essentially, 'height' and 'width' on table elements are treated as 'min-height'
and 'min-width', by tradition.

Comment 22

[Christine Hoffman]

PDT- from beta1 removed; nsbeta2 added

Comment 23

[leger]

Per ekrock mail:
'This is a bug but not a beta2 stopper. Could fix for b3.'

Putting on [nsbeta2-] radar and adding nsbeta3 keyword.

Comment 24

[karnaze (gone)]

Moving to M17.

Comment 25

[karnaze (gone)]

The only heigths that can be set are table, row, and cell and only the row is 
not working. I'm attaching a patch for that in case it is lost before the tree 
opens.

Comment 26

[karnaze (gone)]

Attachment: patch for row height support

Comment 27

[karnaze (gone)]

Attachment: a better patch, ignore the last one

Comment 28

[Marc Attinasi]

Approving for nsbeta3

Comment 29

[buster]

I will review the patch and if ok, check it in.

Comment 30

[buster]

checking in fix for chris.  r=buster

Comment 31

[Christine Hoffman]

Using the following platforms/builds:
Win 98: 8/25/06
Mac 8.6: 8/25/04
Linux Red Hat 6.0 (version 2.2): 8/25/08

bug still not fixed for TABLE, TBODY, THEAD and TFOOT.

Problems:
TABLE: height is not honored, and tfoot and tbody are in reverse order
THEAD: height is not honored
TBODY: height is not honored
TFOOT: height is not honored

Testcases attached.
Reopening bug.

Should these be written up as separate bugs?

Comment 32

[Christine Hoffman]

Attachment: Height on TABLE

Comment 33

[Christine Hoffman]

Attachment: height on TABLE

Comment 34

[Christine Hoffman]

Attachment: height on TBODY

Comment 35

[Christine Hoffman]

Attachment: height on THEAD

Comment 36

[Christine Hoffman]

Attachment: height on TFOOT

Comment 37

[leger]

Adding [nsbeta2-] since PR2 is out and [nsbeta3+] is already indicated.

Comment 38

[buster]

I had marked this fixed based on karnaze's comment:
------- Additional Comments From [e-mail] 2000-05-26 14:20 -------

The only heigths that can be set are table, row, and cell and only the row is 
not working. I'm attaching a patch for that in case it is lost before the tree 
opens.

-----------------------------------------------------------------------------
To me, this implies that Chris thought it was illegal to apply height to a 
rowgroup (THEAD, TFOOT, TBODY).  The fix was just for TR.  So I'll leave it to 
Karnaze to decide what should be done with rowgroups.

Comment 39

[Christine Hoffman]

If you can apply 'height' style to TR, I don't understand why you can't apply 
it to row-groups. I don't find any restriction in the specs. At any rate, 
applying height to TABLE is still broken. I will followup with Karnaze upon his 
return.

Comment 40

[karnaze (gone)]

ChrisD, I'm marking this fixed since Buster checked in the patch to make height 
on <tr> work. If you think that it should work on <tbody>, <thead>, <tfoot>, 
please open a new bug and mark it "future" because it is not a very high 
priority and the spec is unclear on it.

Comment 41

[Christine Hoffman]

TR problem fixed. Remaining issues: 
(1) When height is assigned to TABLE element, TBODY and TFOOT are reversed
(2) Height still does not work on THEAD, TBODY, and TFOOT.

Closing this nsbeta3+ bug out as crucial elements are working (TABLE, TR, TD). 
Will write up separate bugs for (1) and (2) issues.