The default bug view has changed. See this FAQ.

pkix wrapper must print debug output into stderr

RESOLVED FIXED in 3.12

Status

NSS
Libraries
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Alexei Volkov, Assigned: Alexei Volkov)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: PKIXTEST)

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 284223 [details] [diff] [review]
print libpkix debug info into the stderr

Interoperability script uses tstclnt to download server config file and certs into
local file system. When tstclnt is used with -S option is suppose to print out what was downloaded into stdout.
 
Currently libpkix wrapper prints debug output into stdout. This disturbs interoperability testing and should be fixed.
Attachment #284223 - Flags: review?(nelson)
(Assignee)

Updated

10 years ago
Whiteboard: PKIXTEST
Comment on attachment 284223 [details] [diff] [review]
print libpkix debug info into the stderr

r=nelson, with one suggested/requested (not required) change.

> #ifdef DEBUG
>             char *string = pkix_Error2ASCII(node->error, plContext);
>-            printf("Branch search finished with error: \t%s\n", string);
>+            fprintf(stderr, "Branch search finished with error: \t%s\n", string);
>             PKIX_PL_Free(string, NULL);
> #endif

We really don't want debug printfs (whether to stdout or stderr) in our general
builds of NSS shared libs.  So,  I suggest you change the above #ifdef (and *all*
others like it that control the use of debug printfs) as follows:

>-#ifdef DEBUG
>+#ifdef DEBUG_volkov
Attachment #284223 - Flags: review?(nelson) → review+
(Assignee)

Comment 2

10 years ago
the patch committed with suggested change.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.