Last Comment Bug 399236 - pkix wrapper must print debug output into stderr
: pkix wrapper must print debug output into stderr
Status: RESOLVED FIXED
PKIXTEST
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.12
: All All
: -- normal (vote)
: 3.12
Assigned To: Alexei Volkov
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-09 14:39 PDT by Alexei Volkov
Modified: 2007-10-09 15:30 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
print libpkix debug info into the stderr (4.51 KB, patch)
2007-10-09 14:39 PDT, Alexei Volkov
nelson: review+
Details | Diff | Review

Description Alexei Volkov 2007-10-09 14:39:42 PDT
Created attachment 284223 [details] [diff] [review]
print libpkix debug info into the stderr

Interoperability script uses tstclnt to download server config file and certs into
local file system. When tstclnt is used with -S option is suppose to print out what was downloaded into stdout.
 
Currently libpkix wrapper prints debug output into stdout. This disturbs interoperability testing and should be fixed.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2007-10-09 15:22:32 PDT
Comment on attachment 284223 [details] [diff] [review]
print libpkix debug info into the stderr

r=nelson, with one suggested/requested (not required) change.

> #ifdef DEBUG
>             char *string = pkix_Error2ASCII(node->error, plContext);
>-            printf("Branch search finished with error: \t%s\n", string);
>+            fprintf(stderr, "Branch search finished with error: \t%s\n", string);
>             PKIX_PL_Free(string, NULL);
> #endif

We really don't want debug printfs (whether to stdout or stderr) in our general
builds of NSS shared libs.  So,  I suggest you change the above #ifdef (and *all*
others like it that control the use of debug printfs) as follows:

>-#ifdef DEBUG
>+#ifdef DEBUG_volkov
Comment 2 Alexei Volkov 2007-10-09 15:30:46 PDT
the patch committed with suggested change.

Note You need to log in before you can comment on or make changes to this bug.