399311 - Import OpenLayers test suite

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect)

Description

[(not currently active) Ted Mielczarek]

OpenLayers (a JavaScript slippy map library, ala Google Maps) has "an awesome test suite" according to sayrer.  We should pull this in and import it.

Comment 1

[(not currently active) Ted Mielczarek]

"Pull this in and import it."  Yeah, I mean "run it in an automated fashion."

Comment 2

[Christopher Schmidt]

The better URL is probably:

http://svn.openlayers.org/trunk/openlayers/tests/

Comment 3

[(not currently active) Ted Mielczarek]

I think this would make a good student project.

Comment 4

[jyoti]

Attachment: Openlayers test suite patch 1

Openlayers Test Suite Patch

This is the integration of the Openlayers test suite into the Mozilla (and Mochitest) test suite.
This test suite is meant to go along with the other ajax libraries being tested. (This specific patch should be applied in mozilla/dom/tests/mochitest/ajax/)

As this test suite is a little oversize so I have divided the patch into 3 parts: patch1.txt, patch2.txt, patch3.txt. All of them had to be applied before running make. 
When I had applied the patch in my local mozilla-central directory in order to test, I had got some this kind of output, 

--------------
/home/mango/Desktop/patch1.txt:402: trailing whitespace.
    
/home/mango/Desktop/patch1.txt:414: trailing whitespace.
    window.console = 
/home/mango/Desktop/patch1.txt:420: trailing whitespace.
        
/home/mango/Desktop/patch1.txt:425: trailing whitespace.
        
/home/mango/Desktop/patch1.txt:430: trailing whitespace.
--------------

but when I had used the diff utility between the files I had applied the patch and the file from where I had created the patch, no difference came as such.
For applying the patch its better to use git apply instead of hg import -f as it was not working in my local working directory.

Comment 5

[jyoti]

Attachment: Openlayers test suite patch 2

Comment 6

[jyoti]

Attachment: Openlayers test suite patch 3

Comment 7

[David Humphrey (:humph)]

(In reply to comment #6)

Hey, great to see you making progress here!  A couple of process things:

* When you have a patch that you're working on and you want to put it up so people are aware of it, you can do that and say, "Work in Progress" or "[WIP]" so people know what it is.

* If you have got the patch in a state where you want someone to review it (I see you started to do this earlier), you should set the review flag to ? and then enter a reviewer's bugmail.  Perhaps Ted could do this, or recommend someone who could?  In this case you can use ":luser" which will auto-complete for his full bugmail.

Comment 8

[Damon Sicore (:damons)]

Ted, are you planning to review this?

Comment 9

[(not currently active) Ted Mielczarek]

I just never found time, unfortunately, and it's a lot of code. :-(

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 393749 [details] [diff] [review]
Openlayers test suite patch 1

Punting review to ctalbert, this has sat around for too long.

Comment 11

[cmtalbert]

Comment on attachment 393749 [details] [diff] [review]
Openlayers test suite patch 1

Thanks for the patch.  When we put these frameworks into Mochitest, we have to include a library that ties the ajax library's test runner to the Mochitest test runner.

I read in the README (ajax/openlayers/tests/README.txt) that run-tests.html is the test runner, but that is not included in these patches ( I applied all three to try it out). 

You can see how the test runner is modified by looking at the jquery testrunner here: http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/ajax/jquery/test/data/testrunner.js#147.

You see there that the Jquery specific test runner has been tweaked so that it reports pass/fail status up to the Mochitest framework's SimpleTest API.  This is what you need to do.  

I tried running the tests anyway, on Windows 7 with the latest mozilla-central in case I'd missed something but they failed.

I look forward to your next patch addressing the openlayers testrunner and completing the integration with Mochitest.

Also, please include the version or milestone or revision number of these openlayers tests so that we know when we need to update them going forward.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Please feel free to open a new task issue, if there is a need to integrate a new test suite.
https://bugzilla.mozilla.org/describecomponents.cgi?product=Testing is perhaps a better product fit to file a similar issue.