Case mismatch in nsIMsgNewsFolder.idl (PRint32/PRInt32)

RESOLVED FIXED

Status

MailNews Core
Backend
--
minor
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Bruno 'Aqualon' Escherl, Assigned: Bruno 'Aqualon' Escherl)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

1.28 KB, patch
Karsten Düsterloh
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
See URL, PRint32 is used, but should be PRInt32. Patch to come.
(Assignee)

Comment 1

11 years ago
Created attachment 284336 [details] [diff] [review]
PRint32 -> PRInt32

This fixes the compiler warning.
Assignee: nobody → aqualon
Status: NEW → ASSIGNED
Attachment #284336 - Flags: superreview?(neil)
Attachment #284336 - Flags: review?(mnyromyr)
(Assignee)

Comment 2

11 years ago
That's the VC8 warning:

../../../dist/idl\nsrootidl.idl:69: Case mismatch between `PRInt32'
d:/seamonkeysource/mozilla/mailnews/news/public/nsIMsgNewsFolder.idl:70: and `PRint32'
d:/seamonkeysource/mozilla/mailnews/news/public/nsIMsgNewsFolder.idl:70: (Identifiers should be case-consistent after initial declaration)
Severity: normal → minor
OS: Windows XP → All
Hardware: PC → All

Updated

11 years ago
Attachment #284336 - Flags: review?(mnyromyr) → review+

Comment 3

11 years ago
Comment on attachment 284336 [details] [diff] [review]
PRint32 -> PRInt32

Compiler warning? I'm surprised, I thought .idl was processed by xpidlgen
Attachment #284336 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 4

11 years ago
(In reply to comment #3)
> (From update of attachment 284336 [details] [diff] [review])
> Compiler warning? I'm surprised, I thought .idl was processed by xpidlgen
They are, I saw this warning at stderr while stdout went to grep and thougt it was something from VC itself. But it really was from xpidl.

Comment 5

11 years ago
Landed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.