unknown place: url query keys can cause problems

RESOLVED FIXED in Firefox 3 beta1

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: (not reading, please use seth@sspitzer.org instead))

Tracking

Trunk
Firefox 3 beta1
Points:
---
Bug Flags:
in-testsuite ?
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

ill-formed place: url can cause problems

one problem:

1)  create a folder and make one of the items be a bookmark to an ill-formed place: url.
2)  open the bookmark organizer, and you'll be unable to expand that folder.

another problem is that you can't delete these bookmarks from the menus or toolbars.

an example place uri to try is:

place:folder=3&group=3&queryType=1&applyOptionsToContainers=1&sort=12&thisIsGoingToCauseProblems=1&maxResults=10

found this while working on bug #387996.
Created attachment 284376 [details] [diff] [review]
if we detect an unknown key, warn, but ignore it
Attachment #284376 - Flags: review?(dietrich)
this allows forward / backward compatibility as we add (or remove) place query options.
Assignee: nobody → sspitzer
Comment on attachment 284376 [details] [diff] [review]
if we detect an unknown key, warn, but ignore it

thanks seth, this is preferable behavior.
Attachment #284376 - Flags: review?(dietrich) → review+
another problem this will cause is that we'll fail to backup our bookmarks to html, because we'll fail to get the uri from the nav history result node in nsPlacesImportExportService::WriteItem() and return failure.
Status: NEW → ASSIGNED
Summary: ill-formed place: url can cause problems → unknown place: url query keys can cause problems
Target Milestone: --- → Firefox 3 M9
Depends on: 387996
fixed.

for litmus, try bookmarking the url in comment #0.

Checking in toolkit/components/places/src/nsNavHistoryQuery.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistoryQuery.cpp,v  <--  nsNavHistoryQuery.cpp
new revision: 1.33; previous revision: 1.32
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: in-litmus?
Resolution: --- → FIXED
this is beyond the scope of FFT for Litmus
Flags: in-litmus? → in-litmus-
Flags: in-testsuite?
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.