Closed Bug 399369 Opened 12 years ago Closed 12 years ago

Disable font fallback when a character is in the private use areas

Categories

(Core :: Graphics, defect, P4)

Product:
Core
Component:
Graphics
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta2

People

(Reporter: pavlov, Assigned: pavlov)

Details

Attachments

(1 file, 2 obsolete files)

proper ranges, all merged, etc
1.02 KB, patch
pavlov
: review+
Details | Diff | Splinter Review 
Since the private use area is undefined we should only look at fonts we were asked to look at and not look at other fonts on the system for these code points.
Attached patch fix (obsolete) — — Splinter Review
Attachment #284377 - Flags: review?(vladimir)
Attached patch with all the ranges now! (obsolete) — — Splinter Review
Attachment #284377 - Attachment is obsolete: true
Attachment #284382 - Flags: review?(smontagu)
Attachment #284382 - Flags: approval1.9?
Attachment #284377 - Flags: review?(vladimir)
Comment on attachment 284382 [details] [diff] [review]
with all the ranges now!

>+        // don't look in other fonts if the character is in a Private Use Area
>+        if ((ch >= 0xE000   && ch < 0xF900) || 
>+            (ch >= 0xF0000  && ch < 0xFFFFF) || 
>+            (ch >= 0x100000 && ch < 0x10FFFF))
>+            return selectedFont;
>+

The last two ranges are contiguous, so you can just do
              (ch >= 0xF0000 && ch <= 0x10FFFF))
Attachment #284382 - Flags: review?(smontagu) → review+
QA Contact: pavlov → thebes
Assignee: nobody → pavlov
Attachment #284382 - Attachment is obsolete: true
Attachment #286737 - Flags: review+
Attachment #284382 - Flags: approval1.9?
Flags: blocking1.9+
Target Milestone: --- → mozilla1.9 M10
Priority: -- → P4
fixed
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.