Support custom wizard images

RESOLVED FIXED in Firefox 3 beta1

Status

()

Firefox
Installer
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Trunk
Firefox 3 beta1
x86
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

PRD item INST-007a
Created attachment 284648 [details]
Updated AppAssocReg NSIS plugin

I had a chance to update the plugin for setting default apps on Vista.
http://nsis.sourceforge.net/Application_Association_Registration_plug-in
Created attachment 284672 [details] [diff] [review]
patch rev2
Attachment #284658 - Attachment is obsolete: true
Created attachment 284674 [details] [diff] [review]
patch -w rev2
Attachment #284674 - Flags: review?(sspitzer)
Whiteboard: [has patch][need review sspitzer]
Comment on attachment 284674 [details] [diff] [review]
patch -w rev2

r=sspitzer

one question, why are we wrapping paths with quotes now (where we were not before?)
Attachment #284674 - Flags: review?(sspitzer) → review+
(In reply to comment #5)
> (From update of attachment 284674 [details] [diff] [review])
> r=sspitzer
> 
> one question, why are we wrapping paths with quotes now (where we were not
> before?)
That's me being more careful as I get better acquainted with NSIS.
Comment on attachment 284674 [details] [diff] [review]
patch -w rev2

Requesting a1.9 approval for PRD item INST-007a
Attachment #284674 - Flags: approval1.9?
Whiteboard: [has patch][need review sspitzer]

Updated

11 years ago
Attachment #284674 - Flags: approval1.9? → approval1.9+
Checked in to trunk
Checking in mozilla/toolkit/mozapps/installer/windows/nsis/AppAssocReg.dll;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/AppAssocReg.dll,v  <--  AppAssocReg.dll
initial revision: 1.1
done
Checking in mozilla/browser/installer/windows/nsis/installer.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/installer.nsi,v  <--  installer.nsi
new revision: 1.37; previous revision: 1.36
done
Checking in mozilla/browser/installer/windows/nsis/shared.nsh;
/cvsroot/mozilla/browser/installer/windows/nsis/shared.nsh,v  <--  shared.nsh
new revision: 1.16; previous revision: 1.15
done
Checking in mozilla/browser/installer/windows/nsis/uninstaller.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/uninstaller.nsi,v  <--  uninstaller.nsi
new revision: 1.14; previous revision: 1.13
done
Checking in mozilla/toolkit/mozapps/installer/windows/nsis/makensis.mk;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/makensis.mk,v  <--  makensis.mk
new revision: 1.15; previous revision: 1.14
done
Checking in mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh,v  <--  common.nsh
new revision: 1.30; previous revision: 1.29
done
Removing mozilla/toolkit/mozapps/installer/windows/nsis/SetVistaDefaultApp.dll;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/SetVistaDefaultApp.dll,v  <--  SetVistaDefaultApp.dll
new revision: delete; previous revision: 1.1
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
FYI, "fx-win32-tbox" on http://tinderbox.mozilla.org/MozillaExperimental/
turned red with this checkin.  The log file says:

Processing script file: "uninstaller.nsi"
Invalid command: RequestExecutionLevel
Error in script "uninstaller.nsi" on line 45 -- aborting creation process
That Tinderbox needs to be upgraded to use MozillaBuild. I can ifdef it to make it go green though it really should be fixed by upgrading the build environment.
Filed Bug 400509 for the fx-win32-tbox breakage
rstrong: I am looking for some help on how to verify this bug on Vista. Thanks.
You need to log in before you can comment on or make changes to this bug.