399381 - Support custom wizard images

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

PRD item INST-007a

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: Updated AppAssocReg NSIS plugin

I had a chance to update the plugin for setting default apps on Vista.
http://nsis.sourceforge.net/Application_Association_Registration_plug-in

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch -w rev2

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 284674 [details] [diff] [review]
patch -w rev2

r=sspitzer

one question, why are we wrapping paths with quotes now (where we were not before?)

Comment 6

[Robert Strong (they/them - no direct email)]

(In reply to comment #5)
> (From update of attachment 284674 [details] [diff] [review])
> r=sspitzer
> 
> one question, why are we wrapping paths with quotes now (where we were not
> before?)
That's me being more careful as I get better acquainted with NSIS.

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 284674 [details] [diff] [review]
patch -w rev2

Requesting a1.9 approval for PRD item INST-007a

Comment 8

[Robert Strong (they/them - no direct email)]

Checked in to trunk
Checking in mozilla/toolkit/mozapps/installer/windows/nsis/AppAssocReg.dll;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/AppAssocReg.dll,v  <--  AppAssocReg.dll
initial revision: 1.1
done
Checking in mozilla/browser/installer/windows/nsis/installer.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/installer.nsi,v  <--  installer.nsi
new revision: 1.37; previous revision: 1.36
done
Checking in mozilla/browser/installer/windows/nsis/shared.nsh;
/cvsroot/mozilla/browser/installer/windows/nsis/shared.nsh,v  <--  shared.nsh
new revision: 1.16; previous revision: 1.15
done
Checking in mozilla/browser/installer/windows/nsis/uninstaller.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/uninstaller.nsi,v  <--  uninstaller.nsi
new revision: 1.14; previous revision: 1.13
done
Checking in mozilla/toolkit/mozapps/installer/windows/nsis/makensis.mk;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/makensis.mk,v  <--  makensis.mk
new revision: 1.15; previous revision: 1.14
done
Checking in mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh,v  <--  common.nsh
new revision: 1.30; previous revision: 1.29
done
Removing mozilla/toolkit/mozapps/installer/windows/nsis/SetVistaDefaultApp.dll;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/SetVistaDefaultApp.dll,v  <--  SetVistaDefaultApp.dll
new revision: delete; previous revision: 1.1
done

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: as checked in

Comment 10

[Mats Palmgren (inactive)]

FYI, "fx-win32-tbox" on http://tinderbox.mozilla.org/MozillaExperimental/
turned red with this checkin.  The log file says:

Processing script file: "uninstaller.nsi"
Invalid command: RequestExecutionLevel
Error in script "uninstaller.nsi" on line 45 -- aborting creation process

Comment 11

[Robert Strong (they/them - no direct email)]

That Tinderbox needs to be upgraded to use MozillaBuild. I can ifdef it to make it go green though it really should be fixed by upgrading the build environment.

Comment 12

[Robert Strong (they/them - no direct email)]

Filed Bug 400509 for the fx-win32-tbox breakage

Comment 13

[Marcia Knous [:marcia]]

rstrong: I am looking for some help on how to verify this bug on Vista. Thanks.