399402 - Make about:plugins without CSS more readable

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jesse Ruderman]

Attachment: patch

about:plugins becomes almost unreadable when saved and then uploaded to Bugzilla (e.g. for troubleshooting).  This patch fixes that by making two simple changes to the HTML:

1. Use <h1> and <h2> instead of <div> for the in-page title and the per-plugin headers.

2. Give the table border="1".

It also makes corresponding changes to the CSS, so it doesn't affect the appearance of about:plugins when the page is viewed normally.

The first change (using proper header elements) should help accessibility, too.

Comment 1

[Aaron Leventhal]

Comment on attachment 284404 [details] [diff] [review]
patch

Thanks for using headings, but I shouldn't be r='ing here.

Comment 2

[[e-mail]]

Comment on attachment 284404 [details] [diff] [review]
patch

Two other changes to consider:
1) change <div id="outside"> to <blockquote id="outside"> (and div#outside to #outside)
2) also add width="100%" to the tables (and appropriate widths to the th elements)

Nit: pinstripe and modern also have plugins.css files; they might need to be updated too.

Comment 3

[Damon Sicore (:damons)]

Comment on attachment 284404 [details] [diff] [review]
patch

a=release drivers

Comment 4

[Jesse Ruderman]

Patch checked in.