Closed Bug 399450 Opened 12 years ago Closed 12 years ago
When editing topic edit mode is left on any loss of focus
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:220.127.116.11) Gecko/20070914 Firefox/18.104.22.168 Build Identifier: ChatZilla 0.9.78.1 [Firefox 22.214.171.124/2007091417] When I want to edit the topic of a channel, any click outside the editing line results in a loss of what i edited before / loss of focus.. Its prolly intended t prevent one from accidently editing. Maybe protect the edit with confirmation box instead. Reproducible: Always Steps to Reproduce: 1. 2. 3.
I think a confirmation box would be really annoying. If you mistakenly click in the topic as an op, it should be easy to "undo" that operation. Unless there is a better proposal for alternative UI I'm very tempted to WONTFIX this.
A modal dialog or anything else which affects focus is out, as we'd have to start playing complicated games with tracking focus and why it left the textbox and such. A possible compromise: on loss of focus, leave edit mode only if no changes have been made to the text. If you've edited it, you need to press Esc with the topic textbox focused to cancel it. Something like that might work, but the discoverability of Esc is low, so needs work.
We could have a Cancel button next to it?
Status: UNCONFIRMED → NEW
Ever confirmed: true
The only thing I'm not really happy with is that the cancel button still wraps at smaller window sizes, but I don't see a straightforwards CSS way to fix that.
Assignee: rginda → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 323395 [details] [diff] [review] Add cancel button, be less happy to cancel edit That 90% needs to die a horrible death at some point, but r=silver for 0.9.83.
Attachment #323395 - Flags: review?(silver) → review+
Checking in mozilla/extensions/irc/locales/en-US/chrome/chatzilla.properties; /cvsroot/mozilla/extensions/irc/locales/en-US/chrome/chatzilla.properties,v <-- chatzilla.properties new revision: 1.160; previous revision: 1.159 done Checking in mozilla/extensions/irc/xul/content/output-window.html; /cvsroot/mozilla/extensions/irc/xul/content/output-window.html,v <-- output-window.html new revision: 1.12; previous revision: 1.11 done Checking in mozilla/extensions/irc/xul/content/output-window.js; /cvsroot/mozilla/extensions/irc/xul/content/output-window.js,v <-- output-window.js new revision: 1.22; previous revision: 1.21 done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.