399526 - let the offline-app permission apply to subdomains

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Dave Camp (:dcamp)]

testExactPermission() is used to decide whether a site can use the offline APIs, so subdomains don't inherit the permission.

testPermission() is used in most (all?) other consumers of the permission manager.  So for consistency's sake it would make sense to switch the offline-app permission to be used this way too.

Comment 1

[Dave Camp (:dcamp)]

This is tougher than just switching to testPermission().  When you clear out an offline domain, we clear its globalStorage and offline cache entries by looking for entries which match the domain.  We'll miss data added by subdomains if we just switch to testExactPermission.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: v1 [Checkin comment 3]

This seems to be a sufficient solution with what we have now.

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 391096 [details] [diff] [review]
v1 [Checkin comment 3]

http://hg.mozilla.org/mozilla-central/rev/c726007b8eef

This bug is blocking all-wanted bug, we have to get this patch on all branches.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 391096 [details] [diff] [review]
v1 [Checkin comment 3]

We certainly don't need this on 1.8.1 anymore -- we've got no supported offline-app-using products on that branch.

Didn't quite understand the reasons for needing this on the other old branches, and would be more comfortable approving if it's deemed important enough for 1.9.2

Comment 5

[Honza Bambas (:mayhemer)]

This blocks bug 367373 that is wanted on 1.9.2 and 1.9.1. Probably not on 1.8.1 and older.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 391096 [details] [diff] [review]
v1 [Checkin comment 3]

I don't think we want to mess with this on the 1.9.0 branch if we don't have to.

Comment 7

[Samuel Sidler (old account; do not CC)]

Comment on attachment 391096 [details] [diff] [review]
v1 [Checkin comment 3]

We won't take this on 1.9.1. We're getting close to releasing 1.9.2 and are hoping to eventually auto-update users from 1.9.1 so you should get approval for that release.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 391096 [details] [diff] [review]
v1 [Checkin comment 3]

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.

Comment 9

[Honza Bambas (:mayhemer)]

Nominating for 1.9.3 blocking.